Skip to content

[webview_flutter_android] Fix race condition in flaky test #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2023
Merged

[webview_flutter_android] Fix race condition in flaky test #5037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
924a08c
improve test
bparrishMines Sep 29, 2023
9b13529
Merge branch 'main' of github.com:flutter/packages into webview_flake
bparrishMines Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...flutter/webview_flutter_android/example/integration_test/legacy/webview_flutter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,9 @@ Future<void> main() async {
'test_header': 'flutter_test_header'
};
await controller.loadUrl(headersUrl, headers: headers);
final String? currentUrl = await controller.currentUrl();
expect(currentUrl, headersUrl);

await pageStarts.stream.firstWhere((String url) => url == currentUrl);
await pageLoads.stream.firstWhere((String url) => url == currentUrl);
await pageStarts.stream.firstWhere((String url) => url == headersUrl);
await pageLoads.stream.firstWhere((String url) => url == headersUrl);

final String content = await controller
.runJavascriptReturningResult('document.documentElement.innerText');
Expand Down