[flutter_markdown] Code decoration #5060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
domesticmouse
approved these changes
Oct 2, 2023
|
PTAL @stuartmorgan |
|
Adding @tarrinneal, who is interested in becoming involved in |
tarrinneal
approved these changes
Oct 2, 2023
tarrinneal
reviewed
Oct 2, 2023
|
Thanks for making that change! everything lgtm! |
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2023
flutter/packages@e2ac440...c7008cf 2023-10-03 [email protected] [webview_flutter_wkwebview] Fixes bug where `WebkitWebViewController.getUserAgent` was incorrectly returning an empty String (flutter/packages#5062) 2023-10-02 [email protected] [flutter_markdown] Code decoration (flutter/packages#5060) 2023-10-02 [email protected] [webview_flutter] Exposes missing `JavaScriptLogLevel` from platform interface (flutter/packages#5061) 2023-10-02 [email protected] Roll Flutter from d42313c to 57ed724 (11 revisions) (flutter/packages#5059) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@e2ac440...c7008cf 2023-10-03 [email protected] [webview_flutter_wkwebview] Fixes bug where `WebkitWebViewController.getUserAgent` was incorrectly returning an empty String (flutter/packages#5062) 2023-10-02 [email protected] [flutter_markdown] Code decoration (flutter/packages#5060) 2023-10-02 [email protected] [webview_flutter] Exposes missing `JavaScriptLogLevel` from platform interface (flutter/packages#5061) 2023-10-02 [email protected] Roll Flutter from d42313c to 57ed724 (11 revisions) (flutter/packages#5059) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
Because of using `DecoratedBox` for code block the content is above the decoration. This PR replaces `DecoratedBox` with `Container`.  Issue: flutter/flutter#135858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of using
DecoratedBoxfor code block the content is above the decoration. This PR replacesDecoratedBoxwithContainer.Issue: flutter/flutter#135858
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.