Skip to content

[flutter image] Changed image link to use image within package #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2023
Merged

[flutter image] Changed image link to use image within package #5326

merged 3 commits into from
Nov 28, 2023

Conversation

Nitin-Poojary
Copy link
Contributor

Changed image link to use image within package.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g
stuartmorgan-g requested changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a version change and CHANGELOG entry since it changes the file that's published on the example tab on pub.dev.

packages/flutter_image/example/lib/main.dart Outdated
String getUrlFromAssetAsNetworkSource() {
return 'https://github.com/flutter/packages/blob/2e1673307ff7454aff40b47024eaed49a9e77e81/packages/flutter_markdown/example/assets/logo.png';
String getUrlForAssetAsNetworkSource(String assetKey) {
return 'https://github.com/flutter/packages/blob/b96a6dae0ca418cf1e91633f275866aa9cffe437/packages/flutter_image/example/$assetKey.png?raw=true';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is png hard-coded, but the filename not? If the caller can pass an arbitrary asset, there's no guarantee that it would be a png.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, I will fix it.

@Nitin-Poojary Nitin-Poojary force-pushed the flutter_image/fixing_todo branch from 76a4820 to 0784ee4 Compare November 19, 2023 12:58
@Nitin-Poojary
Copy link
Contributor Author

Nitin-Poojary commented Nov 19, 2023 •
edited
Loading

Why is tree-status failing, is it something related to this pr?

@stuartmorgan-g
Copy link
Contributor

Why is tree-status failing

Because the tree was closed at the time.

is it something related to this pr?

No, tree-status is unrelated to PRs.

@Nitin-Poojary
Copy link
Contributor Author

Okay, Thanks.

stuartmorgan-g
stuartmorgan-g requested changes Nov 27, 2023
View reviewed changes
packages/flutter_image/CHANGELOG.md Outdated
@@ -1,4 +1,8 @@
## NEXT
## 4.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a new feature; it should be 4.1.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I tried that before but the test failed saying Incorrectly updated version. Like it is failing now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that you were adding two different versions to the CHANGELOG. Why are you adding both .10 and .11 at the same time? The current version is .9, so the next version should be .10 (as the error message says).

Copy link
Contributor Author

@Nitin-Poojary Nitin-Poojary Nov 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's because before the latest version was marked as NEXT so I changed it to 4.1.10 and marked mine as 4.1.11. So should I add both mine and and previously NEXT as one 4.1.10?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#updating-a-changelog-that-has-a-next

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Nitin-Poojary Nitin-Poojary force-pushed the flutter_image/fixing_todo branch from 005254f to 7dd60c7 Compare November 28, 2023 15:30
stuartmorgan-g
stuartmorgan-g approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

test-exempt: code refactor with no semantic change

@stuartmorgan-g
Copy link
Contributor

@tarrinneal Could you do the secondary review on this?

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 28, 2023
@auto-submit auto-submit bot merged commit 702d497 into flutter:main Nov 28, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 29, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
702d497 [flutter image] Changed image link to use image within package (
f1e88cf 
flutter/packages#5326)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
Roll Packages from 3c05466 to e4aaba8 (5 revisions) (#139232)
85d311d 
flutter/packages@3c05466...e4aaba8

2023-11-28 [email protected] [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471)
2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483)
2023-11-28 [email protected] [flutter image] Changed image link to use image within package (flutter/packages#5326)
2023-11-28 [email protected] camera_android: Camera.java pausePreview null check (flutter/packages#5265)
2023-11-28 [email protected] [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll @caseycrogers
Roll Packages from 3c05466 to e4aaba8 (5 revisions) (flutter#139232)
a79eccf 
flutter/packages@3c05466...e4aaba8

2023-11-28 [email protected] [rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutter/packages#5471)
2023-11-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.20 to 1.9.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5483)
2023-11-28 [email protected] [flutter image] Changed image link to use image within package (flutter/packages#5326)
2023-11-28 [email protected] camera_android: Camera.java pausePreview null check (flutter/packages#5265)
2023-11-28 [email protected] [webview_flutter] Add listener for content offset (Platform Interface) (flutter/packages#5427)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nitin-Poojary @stuartmorgan-g @tarrinneal