Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

johnmccutchan · 2023-11-15T22:17:24Z

The Google Maps LATEST renderer always uses a TextureView. We can use a signal from this TextureView to perform view invalidation that fixes the rendering glitches (missing updates) in TLHC mode.

NOTE: We have an internal bug 311013682 requesting an official way of achieving this functionality but if the bug is ever acted on it will take many months/years before we can rely on this functionality.

In the meantime, chain the internal SurfaceTextureListener with our own and piggyback on the OnSurfaceTextureUpdated callback to invalidate the MapView.

Fixes flutter/flutter#103686

Tested on an emulator and a physical device (Pixel 6 Pro).

flutter-dashboard · 2023-11-15T22:17:27Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g

We should update https://pub.dev/packages/google_maps_flutter_android#texture-layer-hybrid-composition with new guidance. Although if possible, we should also switch the default if this resolves the issue (and leave the switch only as an escape hatch if there are surprise issues). I think this would address all cases:

LATEST would always get this codepath (and work)
LEGACY would presumably either get this codepath (and work) or hit the SurfaceView codepath in Maps and then automatically fall out of TLHC anyway due to the engine fallback logic (so work).

Does that sound right?

...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

johnmccutchan · 2023-11-16T16:44:13Z

We should update https://pub.dev/packages/google_maps_flutter_android#texture-layer-hybrid-composition with new guidance. Although if possible, we should also switch the default if this resolves the issue (and leave the switch only as an escape hatch if there are surprise issues). I think this would address all cases:

LATEST would always get this codepath (and work)

LEGACY would presumably either get this codepath (and work) or hit the SurfaceView codepath in Maps and then automatically fall out of TLHC anyway due to the engine fallback logic (so work).

Does that sound right?

I've updated the docs, PTAL.

...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart

packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md

packages/google_maps_flutter/google_maps_flutter_android/README.md

...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart

packages/google_maps_flutter/google_maps_flutter_android/README.md

...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

The Google Maps LATEST renderer always uses a TextureView. We can use a signal from this TextureView to perform view invalidation that fixes the rendering glitches (missing updates) in TLHC mode. NOTE: We have an internal bug 311013682 requesting an official way of achieving this functionality but if the bug is ever acted on it will take many months/years before we can rely on this functionality. In the meantime, chain the internal SurfaceTextureListener with our own and piggyback on the OnSurfaceTextureUpdated callback to invalidate the MapView. Fixes flutter/flutter#103686 Tested on an emulator and a physical device (Pixel 6 Pro).

stuartmorgan-g

LGTM with nit

stuartmorgan-g · 2023-11-29T17:32:46Z

packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md


+* Fixes missing updates in TLHC mode.
+* Switched default display mode to TLHC mode.


Nit: Switches

(Per our style guide for changelogs.)

…ST renderer (flutter/packages#5408)

flutter/packages@e4aaba8...bc72d15 2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524) 2023-11-30 [email protected] [pointer_interceptor] Add platform interface (flutter/packages#5499) 2023-11-29 [email protected] Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519) 2023-11-29 [email protected] Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rer (flutter#5408) The Google Maps LATEST renderer always uses a TextureView. We can use a signal from this TextureView to perform view invalidation that fixes the rendering glitches (missing updates) in TLHC mode. NOTE: We have an internal bug 311013682 requesting an official way of achieving this functionality but if the bug is ever acted on it will take many months/years before we can rely on this functionality. In the meantime, chain the internal SurfaceTextureListener with our own and piggyback on the OnSurfaceTextureUpdated callback to invalidate the MapView. Fixes flutter/flutter#103686 Tested on an emulator and a physical device (Pixel 6 Pro).

flutter/packages@e4aaba8...bc72d15 2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524) 2023-11-30 [email protected] [pointer_interceptor] Add platform interface (flutter/packages#5499) 2023-11-29 [email protected] Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519) 2023-11-29 [email protected] Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rer (flutter#5408) The Google Maps LATEST renderer always uses a TextureView. We can use a signal from this TextureView to perform view invalidation that fixes the rendering glitches (missing updates) in TLHC mode. NOTE: We have an internal bug 311013682 requesting an official way of achieving this functionality but if the bug is ever acted on it will take many months/years before we can rely on this functionality. In the meantime, chain the internal SurfaceTextureListener with our own and piggyback on the OnSurfaceTextureUpdated callback to invalidate the MapView. Fixes flutter/flutter#103686 Tested on an emulator and a physical device (Pixel 6 Pro).

johnmccutchan requested a review from reidbaker as a code owner November 15, 2023 22:17

github-actions bot added p: google_maps_flutter platform-android labels Nov 15, 2023

johnmccutchan requested a review from stuartmorgan-g November 15, 2023 22:17

johnmccutchan force-pushed the fix_invalidation_logic branch from 7817cf1 to 8d0b2bf Compare November 15, 2023 22:28

stuartmorgan-g requested changes Nov 16, 2023

View reviewed changes

johnmccutchan force-pushed the fix_invalidation_logic branch from 8d0b2bf to 3e63e37 Compare November 16, 2023 16:47

johnmccutchan requested a review from stuartmorgan-g November 16, 2023 16:47

johnmccutchan force-pushed the fix_invalidation_logic branch 2 times, most recently from 2fef5b7 to e876142 Compare November 16, 2023 17:20

stuartmorgan-g reviewed Nov 19, 2023

View reviewed changes

johnmccutchan force-pushed the fix_invalidation_logic branch 3 times, most recently from aff0ac9 to 5598ba1 Compare November 21, 2023 03:41

johnmccutchan force-pushed the fix_invalidation_logic branch from 5598ba1 to 0a38254 Compare November 27, 2023 21:25

This was referenced Nov 27, 2023

google_maps_flutter android performance flutter/flutter#113381

Closed

Permit a null response in TextureAndroidViewController flutter/flutter#139151

Closed

johnmccutchan force-pushed the fix_invalidation_logic branch 6 times, most recently from 77ccc8f to df36585 Compare November 28, 2023 19:31

johnmccutchan requested a review from stuartmorgan-g November 28, 2023 20:03

reidbaker approved these changes Nov 29, 2023

View reviewed changes

johnmccutchan force-pushed the fix_invalidation_logic branch from df36585 to af2a040 Compare November 29, 2023 17:09

johnmccutchan force-pushed the fix_invalidation_logic branch from af2a040 to d7bf4aa Compare November 29, 2023 17:11

stuartmorgan-g approved these changes Nov 29, 2023

View reviewed changes

johnmccutchan merged commit e393d45 into flutter:main Nov 29, 2023

engine-flutter-autoroll mentioned this pull request Nov 30, 2023

Roll Packages from e4aaba833261 to bc72d15c95a5 (4 revisions) flutter/flutter#139307

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2023

e393d45 Fix Google Maps rendering issues in TLHC mode when using LATE…

e9dca6e

…ST renderer (flutter/packages#5408)

note11g mentioned this pull request Jan 4, 2024

Android 9 (SDK 28) 이하 버전에서 위젯 전체가 검은 화면으로 렌더링되는 문제 note11g/flutter_naver_map#135

Closed

reidbaker mentioned this pull request Jan 12, 2024

Dialog Debug #5881

Closed

reidbaker mentioned this pull request Jan 19, 2024

[in_app_purchase] Add play country code api #5941

Merged

12 tasks

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

Uh oh!

johnmccutchan commented Nov 15, 2023

Uh oh!

flutter-dashboard bot commented Nov 15, 2023

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnmccutchan commented Nov 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Nov 29, 2023

Uh oh!

Uh oh!


		* Fixes missing updates in TLHC mode.
		* Switched default display mode to TLHC mode.

Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

Uh oh!

Conversation

johnmccutchan commented Nov 15, 2023

Uh oh!

flutter-dashboard bot commented Nov 15, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnmccutchan commented Nov 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!