-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[pigeon] Adds ProxyApi code generation for Dart #5544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
169cd76
update ast
bparrishMines 9d4f82c
update pigeon_lib
bparrishMines b5d7fcd
fix unit tests
bparrishMines 740a395
add impls for instancemanager and instancemanager api
bparrishMines 304e1a0
add write proxy api impl
bparrishMines 968715d
fix comments
bparrishMines 4628c70
update constructors
bparrishMines 4f643eb
add field impls
bparrishMines 8a87f7f
fix methods
bparrishMines eaef031
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines bb052eb
add helper methods to astproxyapi
bparrishMines c4b7c26
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines e73f881
start of something
bparrishMines 3898970
use dart extends/implements
bparrishMines e216947
validate ast work
bparrishMines 2604466
verify constructor parameters and that all classes are proxyapis
bparrishMines 8fdcca4
inheritance chaecker validator
bparrishMines 5863c68
fix tests
bparrishMines b7ec6ca
undo making validate async
bparrishMines be1f9fb
finish proxyapi validation (maybe)
bparrishMines abf11b6
undo pubspec change
bparrishMines f31df3b
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 8a35b5e
version bump
bparrishMines 9a79ea9
fix lints
bparrishMines 245a322
remove unneccessary cast
bparrishMines 4a5c1c7
formatting
bparrishMines 0d603ae
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines abefd56
fix kotlin tests
bparrishMines 54e4102
fix and add core tests
bparrishMines 00aafe6
ensure constructor parameter names dont overlap field or flutter meth…
bparrishMines c5b3790
some unit tests
bparrishMines fb20cd9
more tests
bparrishMines 3aa0fe9
test fields
bparrishMines 147604a
core tests inheritance and error for double super class naming
bparrishMines d40f976
add code_builder and dart_style to allowed deps
bparrishMines 5286b7a
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 6f887e2
add todo
bparrishMines cc79e77
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines b129a51
use collection for functional methods
bparrishMines 9f52a74
formatting and some updates
bparrishMines e947f31
improve PR looks and commented out code
bparrishMines 4463b09
exclude astproxyapi
bparrishMines f0ca949
regenerate code
bparrishMines 6a5226b
fix last cpp prob
bparrishMines 8e26c08
test generator_tools additions
bparrishMines 5b725c3
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines fcdc09f
change to avoid using $ in code gen
bparrishMines 8572dba
add attached fields to core tests and make instance avoid collisions
bparrishMines fd144c5
fix lists and maps with proxy apis
bparrishMines 7c49057
test dart instance manager
bparrishMines f8f460a
use prefix for attached fields
bparrishMines 2087c10
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 66af298
validate naming and change private codec instance name
bparrishMines 5d4cc54
make a base codec and move attached fields to main class
bparrishMines 382e456
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines eb72b38
fix unit test
bparrishMines 50fc804
fix version error
bparrishMines fbe7c5b
fix test and make instance avoid collisions
bparrishMines df2ecac
add documentation
bparrishMines e157568
create a base class for dart
bparrishMines de987e0
fix tests and lint
bparrishMines 30abd65
replace copyable with a base class
bparrishMines c4e0af3
fix unit tests
bparrishMines 93bafbd
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines cd71bf0
link to immutable
bparrishMines b28e27b
fix instance manager tests
bparrishMines 096d65c
change nonattached to unattached
bparrishMines 4601ce2
change flutter method constructor to newInstance
bparrishMines fff1c9f
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 235464f
add passing proxy api to core test class
bparrishMines 66161fc
verify nonnull attached fields and add docs to callback methods
bparrishMines 1a8b464
make all test callback methods nullable
bparrishMines 5fe2e26
update test pigeon and docs
bparrishMines c0d96c0
add constructor to proxyapisuperclass
bparrishMines ffbe73b
update test pigeon
bparrishMines c4f589e
fix formatting some
bparrishMines 036d12c
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines f5c0ee0
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 2e47909
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 716cd79
dont have repeating code start
bparrishMines 1630fa6
fix up host methods
bparrishMines 6fb56be
update fields
bparrishMines 139e3df
reuse flutter method call code
bparrishMines ec6b94f
gross fix for whether to null out handlers
bparrishMines 89daaea
update setUpMessageHandler with same thing from the commit above
bparrishMines 79f9afa
fix unit tests
bparrishMines cd58d50
use param
bparrishMines f1d4f7a
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines 67f2818
Merge branch 'main' of github.com:flutter/packages into pigeon_wrappe…
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does a constructor have to be a special type? It seems like all the properties are standard method properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is similar to our discussion about
parameter
vsfield
. They overlap but some of the parameters don't apply (e.g.static
/isAsynchronous
). However, if I consider theMethod
as the message call and not the AST class member, then I suppose they are essentially the same thing. I still need to distinguish the difference betweenConstructors
for the Dart code generation, so I think I will keep the class and have it extendMethod
.