Skip to content

[go_router] Fix(docs): Typo in Update navigation.md #5545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[go_router] Fix(docs): Typo in Update navigation.md #5545

merged 2 commits into from
Dec 7, 2023

Conversation

MarinMikael
Copy link
Contributor

Fixed a typo in navigation.md:

context.go('/123, extra: 'abc');

to

context.go('/123', extra: 'abc');

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Changed
```dart
context.go('/123, extra: 'abc');
```
to 
```dart
context.go('/123', extra: 'abc');
```
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
Copy link
Contributor

auto-submit bot commented Dec 7, 2023

auto label is removed for flutter/packages/5545, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@chunhtai chunhtai requested a review from hannah-hyj December 7, 2023 20:44
@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
@auto-submit auto-submit bot merged commit a9ba0fd into flutter:main Dec 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 8, 2023
flutter/packages@15584a3...6cd0657

2023-12-08 [email protected] [gis_web] Correct pub.dev changelog entry. (flutter/packages#5613)
2023-12-08 [email protected] Add the ability to run web_benchmarks with Wasm (flutter/packages#5611)
2023-12-08 [email protected] [google_sign_in] Endorse macOS implementation (flutter/packages#5600)
2023-12-07 [email protected] [go_router_builder] add support to `go_router_builder` for initializing a `ShellRoute` with `observers` (flutter/packages#5563)
2023-12-07 [email protected] [go_router] Fix(docs): Typo in Update navigation.md (flutter/packages#5545)
2023-12-07 [email protected] [two_dimensional_scrollables] Expose addAutomaticKeepAlives in Table delegates (flutter/packages#5597)
2023-12-07 [email protected] [pigeon] Fix pigeon issue_tracker link (flutter/packages#5505)
2023-12-07 [email protected] Pointer interceptor implementations (flutter/packages#5594)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
Fixed a typo in navigation.md:
```dart
context.go('/123, extra: 'abc');
```
to 
```dart
context.go('/123', extra: 'abc');
```

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Fixed a typo in navigation.md:
```dart
context.go('/123, extra: 'abc');
```
to 
```dart
context.go('/123', extra: 'abc');
```

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants