Migrate away from deprecated js_util in web_benchmarks
#5574
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
| @@ -4,10 +4,9 @@ | |||
|
|
|||
| import 'dart:async'; | |||
| import 'dart:html' as html; | |||
There was a problem hiding this comment.
shouldn't we try to drop dart:html, too?
CC @yjbanov
There was a problem hiding this comment.
Filed flutter/flutter#139577 to track this work separately.
|
Closing in favor of #5577 so these two changes can be released together. |
No description provided.