Skip to content

[google_sign_in] Endorse macOS implementation #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 8, 2023
Merged

[google_sign_in] Endorse macOS implementation #5600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6654e65
flutter create without changes
stuartmorgan-g Dec 6, 2023
d6ee3aa
license, format
stuartmorgan-g Dec 6, 2023
72559ea
Add macOS support metadata
stuartmorgan-g Dec 6, 2023
3334dbe
Add configuration to example app
stuartmorgan-g Dec 6, 2023
3a2c8ee
Version bump
stuartmorgan-g Dec 7, 2023
a0a2603
Remove RunnerTests
stuartmorgan-g Dec 7, 2023
5d3a27e
SDK range update
stuartmorgan-g Dec 7, 2023
0619b48
Require 10.15
stuartmorgan-g Dec 7, 2023
b9181ec
adjust readme to match other packages
stuartmorgan-g Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/google_sign_in/google_sign_in/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT
## 6.2.0

* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
* Adds support for macOS.
* Updates minimum supported SDK version to Flutter 3.16.

## 6.1.6

Expand Down
10 changes: 7 additions & 3 deletions packages/google_sign_in/google_sign_in/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

A Flutter plugin for [Google Sign In](https://developers.google.com/identity/).

| | Android | iOS | Web |
|-------------|---------|---------|-----|
| **Support** | SDK 16+ | iOS 11+ | Any |
| | Android | iOS | macOS | Web |
|-------------|---------|-------|--------|-----|
| **Support** | SDK 16+ | 11.0+ | 10.15+ | Any |

## Platform integration

Expand Down Expand Up @@ -42,6 +42,10 @@ The Flutter Favorite
[sign_in_with_apple](https://pub.dev/packages/sign_in_with_apple) plugin could
be an option.

### macOS integration

Please see [instructions on integrating Google Sign-In for macOS](https://pub.dev/packages/google_sign_in_ios#macos-setup).

### Web integration

The new SDK used by the web has fully separated Authentication from Authorization,
Expand Down
7 changes: 7 additions & 0 deletions packages/google_sign_in/google_sign_in/example/macos/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Flutter-related
**/Flutter/ephemeral/
**/Pods/

# Xcode-related
**/dgph
**/xcuserdata/
2 changes: 2 additions & 0 deletions packages/google_sign_in/google_sign_in/example/macos/Flutter/Flutter-Debug.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
#include "ephemeral/Flutter-Generated.xcconfig"
2 changes: 2 additions & 0 deletions packages/google_sign_in/google_sign_in/example/macos/Flutter/Flutter-Release.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
#include "ephemeral/Flutter-Generated.xcconfig"
40 changes: 40 additions & 0 deletions packages/google_sign_in/google_sign_in/example/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

project 'Runner', {
'Debug' => :debug,
'Profile' => :release,
'Release' => :release,
}

def flutter_root
generated_xcode_build_settings_path = File.expand_path(File.join('..', 'Flutter', 'ephemeral', 'Flutter-Generated.xcconfig'), __FILE__)
unless File.exist?(generated_xcode_build_settings_path)
raise "#{generated_xcode_build_settings_path} must exist. If you're running pod install manually, make sure \"flutter pub get\" is executed first"
end

File.foreach(generated_xcode_build_settings_path) do |line|
matches = line.match(/FLUTTER_ROOT\=(.*)/)
return matches[1].strip if matches
end
raise "FLUTTER_ROOT not found in #{generated_xcode_build_settings_path}. Try deleting Flutter-Generated.xcconfig, then run \"flutter pub get\""
end

require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)

flutter_macos_podfile_setup

target 'Runner' do
use_frameworks!
use_modular_headers!

flutter_install_all_macos_pods File.dirname(File.realpath(__FILE__))
end

post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_macos_build_settings(target)
end
end
Loading