Skip to content

[local_auth]: Renamed local_auth_ios to local_auth_darwin #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 9, 2024
Merged

[local_auth]: Renamed local_auth_ios to local_auth_darwin #5809

merged 9 commits into from
Feb 9, 2024

Conversation

OutdatedGuy
Copy link
Contributor

Renames local_auth_ios to local_auth_darwin

resolves flutter/flutter#141020

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added newxtests to check the change I am making, or this PR is test-exempt.
  • All existin and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g
stuartmorgan-g requested changes Jan 5, 2024
View reviewed changes
stuartmorgan-g
stuartmorgan-g requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a full re-review sometime this week, but one initial note from CI:

stuartmorgan-g
stuartmorgan-g requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good now! Just some minor things.

packages/local_auth/local_auth_darwin/example/ios/RunnerTests/FLTLocalAuthPluginTests.m Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should move to darwin/Tests/, and the reference in the Xcode project updated accordingly. (You'll want to change the file's reference type from group-local to project-local in the Xcode UI).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I don't use XCode much so I have no idea what you mean. Can someone else do this instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagman @stuartmorgan @LouiseHsu Any updates on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OutdatedGuy We all have a lot of other things we're working on; if you want someone else to do this, you'll need to wait until one of us has time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed this change.

@jmagman jmagman self-requested a review January 17, 2024 21:57
@stuartmorgan-g
Copy link
Contributor

This will need to be reconciled with main due to the change from iOS 11 to iOS 12 as a minimum version.

jmagman
jmagman approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you rebase and fix up the merge conflicts again, then we're ready to merge. Really appreciate you tackling this, looking forward to the macOS support on top of this!

jmagman
jmagman reviewed Feb 7, 2024
View reviewed changes
packages/local_auth/local_auth_darwin/darwin/local_auth_darwin.podspec
@@ -2,7 +2,7 @@
# To learn more about a Podspec see http://guides.cocoapods.org/syntax/podspec.html
Copy link
Member

@jmagman jmagman Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this needs the PrivacyInfo.xcprivacy pulled in and resource_bundles updated to local_auth_darwin_privacy:

 -> local_auth_darwin (0.0.1)
    - NOTE  | url: The URL (https://pub.dev/packages/local_auth_darwin) is not reachable.
    - ERROR | [iOS] file patterns: The `resource_bundles` pattern for `local_auth_ios_privacy` did not match any file.

Log

See https://github.com/flutter/packages/pull/5846/files#diff-3224e4fc5e9a47bae7d7c5dcc243e869174b97b0b4e8572a6e58fde8c0b3f5d5

@jmagman
Copy link
Member

jmagman commented Feb 8, 2024

Can you also switch

 Unknown directory "packages/local_auth/local_auth_ios" in CODEOWNERS

packages/CODEOWNERS

Line 91 in 316bde0

packages/local_auth/local_auth_ios/** @louisehsu

Hopefully almost done 🤞

@jmagman
Copy link
Member

jmagman commented Feb 9, 2024

@stuartmorgan can you take a look at this again? Blocked on your change request.

stuartmorgan-g
stuartmorgan-g approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 9, 2024
@auto-submit auto-submit bot merged commit 0a69259 into flutter:main Feb 9, 2024
@stuartmorgan-g
Copy link
Contributor

I'll prep a PR to switch local_auth from depending on local_auth_ios to local_auth_darwin, since we'll need to have that ready in case we need to push any iOS fixes, but will hold off for a little bit on landing it so that if macOS support is added to _darwin quickly we can combine that with macOS endorsement.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
0a69259 [local_auth]: Renamed local_auth_ios to local_auth_darwin (…
524f9bc 
…flutter/packages#5809)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
Roll Packages from 11152d2 to 0a69259 (4 revisions) (#143306)
82668f1 
flutter/packages@11152d2...0a69259

2024-02-09 [email protected] [local_auth]: Renamed `local_auth_ios` to `local_auth_darwin` (flutter/packages#5809)
2024-02-09 [email protected] [webview_flutter] Add listener for content offset (flutter/packages#3444)
2024-02-09 [email protected] [go_router] Expose full `Uri` on `GoRouterState` in `GoRouterRedirect` (flutter/packages#5742)
2024-02-09 [email protected] [webview_flutter] Minor test cleanup (flutter/packages#6031)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
@cristal-node cristal-node mentioned this pull request Feb 28, 2024
Merged
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@OutdatedGuy @arc-yong
[local_auth]: Renamed local_auth_ios to local_auth_darwin (flutte…
5196b14 
…r#5809)

Renames `local_auth_ios` to `local_auth_darwin`

resolves flutter/flutter#141020

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: local_auth platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename local_auth_ios plugin to local_auth_darwin
3 participants
@OutdatedGuy @stuartmorgan-g @jmagman