Skip to content

[pigeon] Adds ProxyApi to AST generation #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 30, 2024

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jan 10, 2024

Part of flutter/flutter#134777.

This adds the @ProxyApi, @attached, and @static annotations and parsing to create the new ProxyApi.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines marked this pull request as draft January 10, 2024 22:11
@bparrishMines bparrishMines removed the request for review from tarrinneal January 10, 2024 22:22
@bparrishMines bparrishMines changed the title update ast [pigeon] Adds ProxyApi to AST generatino Jan 12, 2024
@bparrishMines bparrishMines changed the title [pigeon] Adds ProxyApi to AST generatino [pigeon] Adds ProxyApi to AST generation Jan 12, 2024
@bparrishMines bparrishMines marked this pull request as ready for review January 12, 2024 20:05
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First read through. Nothing too problematic imo. Will approve after another read through.

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. I think this is good to land as is. If @stuartmorgan wants to weigh in, now's the time!

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit auto-submit bot merged commit c0cb0ee into flutter:main Jan 30, 2024
@bparrishMines bparrishMines deleted the pigeon_wrapper_ast branch January 30, 2024 20:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 31, 2024
flutter/packages@25abb5d...5b48c44

2024-01-30 [email protected] [rfw] Enable subscribing to the root of a DynamicContent (flutter/packages#5848)
2024-01-30 [email protected] [pigeon] Adds ProxyApi to AST generation (flutter/packages#5861)
2024-01-30 [email protected] [tool] Exempt federated impl examples from CHANGELOG (flutter/packages#6018)
2024-01-30 [email protected] Manual roll Flutter from 2f6fdf2 to ace9181 (57 revisions) (flutter/packages#6013)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Part of flutter/flutter#134777.

This adds the `@ProxyApi`, `@attached`, and `@static` annotations and parsing to create the new ProxyApi.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: pigeon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants