-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[pigeon] Adds ProxyApi to AST generation #5861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First read through. Nothing too problematic imo. Will approve after another read through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. I think this is good to land as is. If @stuartmorgan wants to weigh in, now's the time!
flutter/packages@25abb5d...5b48c44 2024-01-30 [email protected] [rfw] Enable subscribing to the root of a DynamicContent (flutter/packages#5848) 2024-01-30 [email protected] [pigeon] Adds ProxyApi to AST generation (flutter/packages#5861) 2024-01-30 [email protected] [tool] Exempt federated impl examples from CHANGELOG (flutter/packages#6018) 2024-01-30 [email protected] Manual roll Flutter from 2f6fdf2 to ace9181 (57 revisions) (flutter/packages#6013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#134777. This adds the `@ProxyApi`, `@attached`, and `@static` annotations and parsing to create the new ProxyApi.
Part of flutter/flutter#134777.
This adds the
@ProxyApi
,@attached
, and@static
annotations and parsing to create the new ProxyApi.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.