-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ci] Run check_podspecs on arm Mac bots #5885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I would prefer adjusting the PR to add a new arm64 copy, and then remove the x64 copy when taking this out of bringup
, so that we don't have a coverage gap.
.ci.yaml
Outdated
# support. `pod lint` makes a synthetic target that doesn't respect the | ||
# pod's arch exclusions, so fails to build. | ||
- name: Mac_x64 check_podspecs | ||
- name: Mac_arm64 check_podspecs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in the other issue, you could rename this repo_checks
now to save another 2-PR cycle later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Done. |
properties: | ||
add_recipes_cq: "true" | ||
version_file: flutter_master.version | ||
target_file: macos_check_podspecs.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename to macos_repo_checks.yaml
once Mac_x64 check_podspecs
is removed and it's not shared, or I'll use repo_checks.yaml
but do something to bifurcate the platforms, tbd.
auto label is removed for flutter/packages/5885, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This reverts commit 855e283.
Reverts #5885 Initiated by: jmagman This change reverts the following previous change: Original Description: Fixes flutter/flutter#141493
flutter/packages@7dd0fcb...1a2b780 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Run check_podspecs on arm Mac bots" (flutter/packages#5909) 2024-01-17 [email protected] [various] Update minimum iOS versions to 12.0 (flutter/packages#5902) 2024-01-16 [email protected] [ci] Run check_podspecs on arm Mac bots (flutter/packages#5885) 2024-01-16 [email protected] [pigeon] Fix pigeon test generation missing wrapResponse method. (flutter/packages#5903) 2024-01-16 [email protected] Roll Flutter from 1a2c315 to 8e94423 (2 revisions) (flutter/packages#5897) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/packages#5896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Reverts flutter#5885 Initiated by: jmagman This change reverts the following previous change: Original Description: Fixes flutter/flutter#141493
Fixes flutter/flutter#141493
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.