Skip to content

Bump version number, add to changelog #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

gspencergoog
Copy link
Contributor

No description provided.

@gspencergoog gspencergoog merged commit da31990 into flutter:master Oct 16, 2018
goderbauer pushed a commit that referenced this pull request Feb 3, 2020
stuartmorgan-g pushed a commit to stuartmorgan-g/packages that referenced this pull request Apr 27, 2021
* Add search icon feature

* Show all icons if search box is empty

* feat:Always display search bar

* feat(ui): modify search bar ui

Search bar now has a "search" icon fron cupertino-icons icon set

* fix(ui): reposition search bar icon

* refactor: remove unnecessary css props
stuartmorgan-g pushed a commit to stuartmorgan-g/packages that referenced this pull request Apr 30, 2021
* Add search icon feature

* Show all icons if search box is empty

* feat:Always display search bar

* feat(ui): modify search bar ui

Search bar now has a "search" icon fron cupertino-icons icon set

* fix(ui): reposition search bar icon

* refactor: remove unnecessary css props
junaid1460 referenced this pull request Aug 23, 2022
* Refactor internal classes and methods

- Separate matching from redirection
- Add RouteRedirector typedef
- Add RouteMatcher class
- Add RouteBuilder class
- Add RouteConfiguration class
- Rename and reorganize internal classes and libraries
- Add todo comments

* format

* Sort imports

* Update changelog

* Address code review comments

- Change name back to GoRouterRefreshStream
- Update toString() methods for new naming
- Make fields final
- Add logging to parser
- Add comments
- add tests
- Move function-scope to new library-scope _addRedirect function
- import widgets instead of material where possible

* remove routing library

* Move classes in go_router.dart into separate libraries

* Move Configuration.validate() into constructor

* Remove comment

* use continue in redirect loop

* Fix comments

* Sort imports

* Fix logging in configuration

* add visibleForTesting annotation

* Updates from merge with main

* Format

* Add TODOs to make Router implementation classes private

* Add copyright headers

* Fix tests

* format

* fix comment

* Update packages/go_router/lib/src/parser.dart

Co-authored-by: Loïc Sharma <[email protected]>

* add whitespace

* format

* Hide typedefs that weren't previously exported

* Delete empty file

* add missing import

* Specify version 4.1.2 in pubspec.yaml

* Update packages/go_router/lib/src/builder.dart

Co-authored-by: chunhtai <[email protected]>

* Fix comment

* Add isError and error getters to RouteMatchList

* Add issue links to TODO comments

* Add link to issue for TODO

* Re-apply code from #2306 due to merge conflicts

* Add issue references

Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: chunhtai <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2023
auto-submit bot pushed a commit that referenced this pull request Sep 19, 2023
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking flutter#6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking flutter#5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
stuartmorgan-g pushed a commit that referenced this pull request Oct 25, 2024
* Improve path_parsing performance.

This code:
* Avoiding String.codeUnits.
* Reduces lookups to String.codeUnitAt
* Caches _length
* Builds integer value in a single pass.

String.codeUnits on both JS and VM returns a forwarding CodeUnits class defined here, so all lookups to codeUnits[index] actually go through an extra layer of dispatch.

Combined, all of these changes improve the parsing speed by ~25% when measured with real SVG path data.

parseSvgPathData() timing, measured on a Nexus 2 downclocked to 1GHz.

Before:
Run1: 76,124,392 us
Run2: 75,103,426 us
Run3: 75,481,128 us

After:
Run1: 59,319,622 us
Run2: 58,435,315 us
Run3: 58,478,007 us

* analysis cleanup

Co-authored-by: Dan Field <[email protected]>
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
Parsing, a few test cases
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
Fix error on slider value > max, update flutter min version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant