Skip to content

[pigeon] Fix tool hangs on verbose sub-processes #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[pigeon] Fix tool hangs on verbose sub-processes #6198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/pigeon/tool/shared/process_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,29 @@ Future<int> runProcess(String command, List<String> arguments,
mode:
streamOutput ? ProcessStartMode.inheritStdio : ProcessStartMode.normal,
);

if (streamOutput) {
return process.exitCode;
}

final List<int> stdoutBuffer = <int>[];
final List<int> stderrBuffer = <int>[];
final Future<void> stdoutFuture = process.stdout.forEach(stdoutBuffer.addAll);
final Future<void> stderrFuture = process.stderr.forEach(stderrBuffer.addAll);
final int exitCode = await process.exitCode;
await Future.wait(<Future<void>>[
stdoutFuture,
stderrFuture,
]);

if (exitCode != 0 && logFailure) {
// ignore: avoid_print
print('$command $arguments failed:');
stdout.add(stdoutBuffer);
stderr.add(stderrBuffer);
await Future.wait(<Future<void>>[
process.stdout.pipe(stdout),
process.stderr.pipe(stderr),
stdout.flush(),
stderr.flush(),
]);
}
return exitCode;
Expand Down