Fix error in markdown parsing image dimensions #6518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domesticmouse
approved these changes
Apr 14, 2024
collinjackson
added
the
autosubmit
3 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2024
flutter/packages@78f684c...6698b2d 2024-04-14 [email protected] Fix error in markdown parsing image dimensions (flutter/packages#6518) 2024-04-12 [email protected] [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506) 2024-04-12 [email protected] [video_player] Darwin implementation cleanup (flutter/packages#6507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@78f684c...6698b2d 2024-04-14 [email protected] Fix error in markdown parsing image dimensions (flutter/packages#6518) 2024-04-12 [email protected] [Many] Bump to min minSdkVersion of 19 across all plugins (flutter/packages#6506) 2024-04-12 [email protected] [video_player] Darwin implementation cleanup (flutter/packages#6507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Gracefully handle parsing failures for image width and height in Markdown. Unit tests are provided. Fixes flutter/flutter#146739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully handle parsing failures for image width and height in Markdown. Unit tests are provided.
Fixes flutter/flutter#146739
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.I updated/added relevant documentation (doc comments withNot needed as there was no API change.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.