Add mDNS client #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of mDNS one-shot query. This package uses dart:io and runs only on the Dart VM. [email protected] BUG= Review URL: https://codereview.chromium.org/1426863003 .
On Mac OS the mDNSResponder daemon has opened port 5353 exclusively. Therefore it is not possible to speak the mDNS protocol from Dart using datagram sockets. The native extension uses the Mac OS DNS Service Discovery C API. Updated the copyright notice to use Fletch instead of Dart. BUG= dart-archive/sdk#225 [email protected], [email protected] Review URL: https://codereview.chromium.org/1407123010 .
This reverts commit 7b02aeda7e019a7daa08b2002be956150aaae4e2. [email protected] BUG= Review URL: https://codereview.chromium.org/1413713011 .
This re-lands commit 7b02aeda7e019a7daa08b2002be956150aaae4e2 which was reverted in commit 6fd4f290758b3843ee1ba5a05b37276c73051e27. The following changes has been made: 1. Fixed the include file name for Mac OS compilation 2. Moved the native extension to a deferred loaded library 3. Don't run tests of the native extension on ARM [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1403303012 .
This change adds the ability to query RR types PTR, SRV, and TXT and handle arbitrary responses. [email protected] Review URL: https://codereview.chromium.org/1412063015 .
* Wrong type * Missing export [email protected] BUG= Review URL: https://codereview.chromium.org/1430433005 .
Add a lookup tool. Add a timeout option to both tools. [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1432973002 .
…ords Change to use the API DNSServiceQueryRecord to support all record types. [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1411063006 .
…xtension The mDNS native extension on Mac OS now keeps sending results until the given timeout period has expired. To make that happen changed the thread pumping the results to use select on the privided file descriptor for the given timeout period. [email protected], [email protected] BUG= Review URL: https://codereview.chromium.org/1416833009 .
This adds the new command 'x-discover' which will discover devices with the Fletch agent. This also adds the option to run discovery when asked for the IP address of a remote device. [email protected] BUG= Review URL: https://codereview.chromium.org/1422853009 .
Updated using:
$ find . -type f -exec sed -i 's/Fletch project authors/Dartino project authors/g' {} \;
All tests pass.
[email protected]
Review URL: https://codereview.chromium.org/1649703002 .
Here is what I did, manual steps commented out since this can be run as a script:
rm -rf third_party # Don't replace inside third_party packages
git reset --hard HEAD
mv .git /tmp/.git # don't replace in the index :-)
find . -type f -exec sed -i 's/fletch/dartino/g' {} +
find . -type f -exec sed -i 's/Fletch/Dartino/g' {} +
find . -type f -exec sed -i 's/FLETCH/DARTINO/g' {} +
find . -type f -exec sed -i 's/dartinoc/dartino_compiler/g' {} +
# We still use dart-dependencies-fletch for now for getting third_party deps
find . -type f -exec sed -i 's/dart-dependencies-dartino/dart-dependencies-fletch/g' {} +
# No rename of bot script (tools/bots/fletch.py), will do that in a follow up
mv /tmp/.git .git
git mv pkg/fletch_sdk_readme.md pkg/dartino_sdk_readme.md
git mv pkg/async_helper/fletch.patch pkg/async_helper/dartino.patch
git mv pkg/async_helper/README-fletch.md pkg/async_helper/README-dartino.md
git mv pkg/fletch_agent pkg/dartino_agent
git mv pkg/immi_samples/lib/android/src/main/com/google/fletch pkg/immi_samples/lib/android/src/main/com/google/dartino
git mv pkg/fletch pkg/dartino
git mv pkg/dartino/lib/fletch.dart pkg/dartino/lib/dartino.dart
git mv tests/fletch_tests tests/dartino_tests
git mv tests/dartino_tests/fletch_test_suite.dart tests/dartino_tests/dartino_test_suite.dart
git mv tests/dartino_tests/fletch_tests.status tests/dartino_tests/dartino_tests.status
git mv tests/pkg/fletch_agent tests/pkg/dartino_agent
git mv platforms/raspberry-pi2/data/depend.start.fletch.wheezy platforms/raspberry-pi2/data/depend.start.dartino.wheezy
git mv platforms/raspberry-pi2/data/depend.start.fletch.jessie platforms/raspberry-pi2/data/depend.start.dartino.jessie
git mv platforms/raspberry-pi2/data/depend.stop.fletch.wheezy platforms/raspberry-pi2/data/depend.stop.dartino.wheezy
git mv platforms/raspberry-pi2/data/depend.stop.fletch.jessie platforms/raspberry-pi2/data/depend.stop.dartino.jessie
git mv platforms/stm/event_handler_test/src/fletch_entry.cc platforms/stm/event_handler_test/src/dartino_entry.cc
git mv platforms/stm/disco_fletch platforms/stm/disco_dartino
git mv platforms/stm/disco_dartino/disco_fletch.gyp platforms/stm/disco_dartino/disco_dartino.gyp
git mv platforms/stm/disco_dartino/src/fletch_entry.cc platforms/stm/disco_dartino/src/dartino_entry.cc
git mv platforms/stm/disco_dartino/src/fletch_entry.h platforms/stm/disco_dartino/src/dartino_entry.h
git mv platforms/stm/disco_dartino/disco_fletch.ioc platforms/stm/disco_dartino/disco_dartino.ioc
git mv tools/run_fletch_agent tools/run_dartino_agent
git mv tools/raspberry-pi2/raspbian-scripts/fletch-configuration tools/raspberry-pi2/raspbian-scripts/dartino-configuration
git mv tools/testing/dart/fletch_test_suite.dart tools/testing/dart/dartino_test_suite.dart
git mv tools/testing/dart/fletch_session_command.dart tools/testing/dart/dartino_session_command.dart
git mv tools/testing/dart/fletch_warnings_suite.dart tools/testing/dart/dartino_warnings_suite.dart
git mv tools/bots/sdk_fletch_patched.py tools/bots/sdk_dartino_patched.py
git mv tools/bots/fletch_namer.py tools/bots/dartino_namer.py
git mv tools/fletchc_blaze.dart tools/dartinoc_blaze.dart
git mv tools/servicec/lib/src/resources/java/fletch tools/servicec/lib/src/resources/java/dartino
git mv samples/github/android/GithubMock/app/src/main/java/com/google/fletch samples/github/android/GithubMock/app/src/main/java/com/google/dartino
git mv samples/github/android/GithubSample/app/src/main/java/com/google/fletch samples/github/android/GithubSample/app/src/main/java/com/google/dartino
git mv samples/github/android/GithubSample/app/src/androidTest/java/com/google/fletch samples/github/android/GithubSample/app/src/androidTest/java/com/google/dartino
git mv samples/github/lib/src/github_mock_data/repos/dart-lang/fletch.data samples/github/lib/src/github_mock_data/repos/dart-lang/dartino.data
git mv samples/github/lib/src/github_mock_data/repos/dart-lang/fletch samples/github/lib/src/github_mock_data/repos/dart-lang/dartino
git mv samples/todomvc/android/TodoMVC/app/src/main/java/com/google/fletch samples/todomvc/android/TodoMVC/app/src/main/java/com/google/dartino
git mv samples/todomvc/android/TodoMVC/app/src/androidTest/java/com/google/fletch samples/todomvc/android/TodoMVC/app/src/androidTest/java/com/google/dartino
git mv lib/fletch_mobile.platform lib/dartino_mobile.platform
git mv lib/fletch_embedded.platform lib/dartino_embedded.platform
git mv lib/fletch lib/dartino
git mv lib/dartino/fletch.dart lib/dartino/dartino.dart
git mv .fletch-settings .dartino-settings
git mv include/fletch_relocation_api.h include/dartino_relocation_api.h
git mv include/fletch_api.h include/dartino_api.h
git mv embedded.fletch-settings embedded.dartino-settings
git mv fletch.gyp dartino.gyp
git mv src/shared/fletch.h src/shared/dartino.h
git mv src/shared/fletch.cc src/shared/dartino.cc
git mv src/vm/fletch_api_impl.cc src/vm/dartino_api_impl.cc
git mv src/vm/fletch.cc src/vm/dartino.cc
git mv src/vm/fletch_relocation_api_impl.cc src/vm/dartino_relocation_api_impl.cc
git mv src/vm/fletch_relocation_api_impl.h src/vm/dartino_relocation_api_impl.h
git mv src/vm/fletch_api_impl.h src/vm/dartino_api_impl.h
git mv pkg/fletchc pkg/dartino_compiler
git mv pkg/dartino_compiler/samples/fletchc_driver pkg/dartino_compiler/samples/dartino_compiler_driver
git mv pkg/dartino_compiler/lib/fletch_vm.dart pkg/dartino_compiler/lib/dartino_vm.dart
git mv pkg/dartino_compiler/lib/fletch_system.dart pkg/dartino_compiler/lib/dartino_system.dart
git mv pkg/dartino_compiler/lib/fletch_compiler.dart pkg/dartino_compiler/lib/dartino_compiler.dart
git mv pkg/dartino_compiler/lib/incremental/fletchc_incremental.dart pkg/dartino_compiler/lib/incremental/dartino_compiler_incremental.dart
git mv pkg/dartino_compiler/lib/incremental/fletch_reuser.dart pkg/dartino_compiler/lib/incremental/dartino_reuser.dart
git mv pkg/dartino_compiler/lib/src/fletch_diagnostic_reporter.dart pkg/dartino_compiler/lib/src/dartino_diagnostic_reporter.dart
git mv pkg/dartino_compiler/lib/src/fletch_system_builder.dart pkg/dartino_compiler/lib/src/dartino_system_builder.dart
git mv pkg/dartino_compiler/lib/src/fletch_compiler_implementation.dart pkg/dartino_compiler/lib/src/dartino_compiler_implementation.dart
git mv pkg/dartino_compiler/lib/src/fletch_selector.dart pkg/dartino_compiler/lib/src/dartino_selector.dart
git mv pkg/dartino_compiler/lib/src/fletch_registry.dart pkg/dartino_compiler/lib/src/dartino_registry.dart
git mv pkg/dartino_compiler/lib/src/fletch_system_printer.dart pkg/dartino_compiler/lib/src/dartino_system_printer.dart
git mv pkg/dartino_compiler/lib/src/fletch_constants.dart pkg/dartino_compiler/lib/src/dartino_constants.dart
git mv pkg/dartino_compiler/lib/src/fletch_class_builder.dart pkg/dartino_compiler/lib/src/dartino_class_builder.dart
git mv pkg/dartino_compiler/lib/src/fletch_enqueuer.dart pkg/dartino_compiler/lib/src/dartino_enqueuer.dart
git mv pkg/dartino_compiler/lib/src/fletch_context.dart pkg/dartino_compiler/lib/src/dartino_context.dart
git mv pkg/dartino_compiler/lib/src/fletch_native_descriptor.dart pkg/dartino_compiler/lib/src/dartino_native_descriptor.dart
git mv pkg/dartino_compiler/lib/src/fletch_backend.dart pkg/dartino_compiler/lib/src/dartino_backend.dart
git mv pkg/dartino_compiler/lib/src/fletch_function_builder.dart pkg/dartino_compiler/lib/src/dartino_function_builder.dart
git mv tests/fletchc tests/dartino_compiler
git mv third_party/lk/fletch third_party/lk/dartino
git mv third_party/lk/dartino/project/stm32746g-eval2-fletch.mk third_party/lk/dartino/project/stm32746g-eval2-dartino.mk
git mv third_party/lk/dartino/project/add-fletch-snapshot-section.ld third_party/lk/dartino/project/add-dartino-snapshot-section.ld
git mv third_party/lk/dartino/project/qemu-virt-fletch.mk third_party/lk/dartino/project/qemu-virt-dartino.mk
git mv third_party/lk/dartino/project/stm32f746g-disco-fletch.mk third_party/lk/dartino/project/stm32f746g-disco-dartino.mk
git mv third_party/lk/dartino/app/fletch-fixed third_party/lk/dartino/app/dartino-fixed
git mv third_party/lk/dartino/app/fletch third_party/lk/dartino/app/dartino
gclient sync # pull back dependencies
# Manually fixup dartino_tests/mdns_tests/decode
# Suppress github/lib/src/tests/github_api_test, don't know how test data is generated
# Manually fixup dartino/app/dartino-fixed/rules.mk and dartino/app/dartino/rules.mk dartino_runner.c -> fletch_runner.c
# Manually fixup dartino_tests/debugger/async_test
# Manually fix long line in pkg/dartino_compiler/lib/src/verbs/documentation.dart
# Manually fixup long lines reported by git cl presubmit
[email protected], [email protected]
BUG=
Review URL: https://codereview.chromium.org/1659163007 .
The latest version of the Dart VM require native code for native extensions to be in the same directory as the Dart file inporting it. Closes flutter#588 BUG= dart-archive/sdk#588 [email protected] BUG= Review URL: https://codereview.chromium.org/2206873004 .
|
Seems like CI is expecting that this package depends on Flutter, but it doesn't. Is this the wrong repo, or do we need to update CI for this scenario? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 23, 2023
Manual roll Flutter from 8936504 to f92884c (48 revisions) Manual roll requested by [email protected] flutter/flutter@8936504...f92884c 2023-09-21 [email protected] Rename `debugProfilePlatformChannels` to a constant that works in release mode (flutter/flutter#134922) 2023-09-20 [email protected] Mark ReastaurationManager not disposed (flutter/flutter#134832) 2023-09-20 [email protected] cover more tests with leak tracing (flutter/flutter#134834) 2023-09-20 [email protected] Fix leak in hardware_keyboard_test.dart (flutter/flutter#134380) 2023-09-20 [email protected] Fix memory leak in _SelectableTextState (flutter/flutter#135049) 2023-09-20 [email protected] Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) (flutter/flutter#135169) 2023-09-20 [email protected] [deps] Update package:web dependency. (flutter/flutter#135174) 2023-09-20 [email protected] finer grained logging of Chromium launch sequence (flutter/flutter#135078) 2023-09-20 [email protected] Upgrade AGP version in tracing_tests (flutter/flutter#134671) 2023-09-20 [email protected] Cover cupertino/form_section_test with leak tracing (flutter/flutter#135158) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #7 (flutter/flutter#134943) 2023-09-20 [email protected] Enable strict-inference (flutter/flutter#135043) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #10 (flutter/flutter#135143) 2023-09-20 [email protected] cover more tests with leak tracing (flutter/flutter#134833) 2023-09-20 [email protected] codeisn extension safe iOS framework (flutter/flutter#134966) 2023-09-20 [email protected] Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) (flutter/flutter#135151) 2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments in widgets library (flutter/flutter#134992) 2023-09-20 [email protected] Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) (flutter/flutter#135147) 2023-09-20 [email protected] [Android] Add Java/AGP/Gradle incompatibility warning to `flutter create` (flutter/flutter#131444) 2023-09-20 [email protected] Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter/flutter#135145) 2023-09-20 [email protected] Remove 'must not be null' comments from various libraries. (flutter/flutter#134984) 2023-09-20 [email protected] Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) (flutter/flutter#135142) 2023-09-20 [email protected] Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) (flutter/flutter#135139) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #8 (flutter/flutter#135045) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking #9 (flutter/flutter#135054) 2023-09-20 [email protected] Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) (flutter/flutter#135128) 2023-09-20 [email protected] Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) (flutter/flutter#135102) 2023-09-20 [email protected] Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) (flutter/flutter#135101) 2023-09-20 [email protected] Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) (flutter/flutter#135098) 2023-09-20 [email protected] Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) (flutter/flutter#135096) 2023-09-20 [email protected] Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) (flutter/flutter#135095) 2023-09-20 [email protected] Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) (flutter/flutter#135093) 2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments from material. (flutter/flutter#134991) 2023-09-20 [email protected] Unpin url launcher (remake) (flutter/flutter#134958) 2023-09-20 [email protected] Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (flutter/flutter#135085) 2023-09-20 [email protected] Manual roll Flutter Engine from a7af55c56aa6 to 0d7db40c27fd (7 revisions) (flutter/flutter#135079) 2023-09-20 [email protected] Remove 'must not be null' comments from painting and rendering libraries. (flutter/flutter#134993) 2023-09-20 [email protected] cover more tests with leak tracking (flutter/flutter#134837) 2023-09-20 [email protected] [flutter roll] Revert "Native assets support for Linux" (flutter/flutter#135069) 2023-09-20 [email protected] Manual roll Flutter Engine from 10c480310926 to a7af55c56aa6 (4 revisions) (flutter/flutter#135071) 2023-09-19 [email protected] Retry Linux web tests 1 time on roll presubmit (flutter/flutter#135073) 2023-09-19 [email protected] [web] Encode AssetManifest.bin as JSON and use that on the web. (flutter/flutter#131382) 2023-09-19 [email protected] Specify suggested format in doc comment. (flutter/flutter#134887) 2023-09-19 [email protected] Manual roll Flutter Engine from 28f14e6eec4f to 10c480310926 (6 revisions) (flutter/flutter#135066) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
) Manual roll Flutter from 8936504 to f92884c (48 revisions) Manual roll requested by [email protected] flutter/flutter@8936504...f92884c 2023-09-21 [email protected] Rename `debugProfilePlatformChannels` to a constant that works in release mode (flutter/flutter#134922) 2023-09-20 [email protected] Mark ReastaurationManager not disposed (flutter/flutter#134832) 2023-09-20 [email protected] cover more tests with leak tracing (flutter/flutter#134834) 2023-09-20 [email protected] Fix leak in hardware_keyboard_test.dart (flutter/flutter#134380) 2023-09-20 [email protected] Fix memory leak in _SelectableTextState (flutter/flutter#135049) 2023-09-20 [email protected] Roll Flutter Engine from 39c0f2ea1f53 to 89d864552acd (4 revisions) (flutter/flutter#135169) 2023-09-20 [email protected] [deps] Update package:web dependency. (flutter/flutter#135174) 2023-09-20 [email protected] finer grained logging of Chromium launch sequence (flutter/flutter#135078) 2023-09-20 [email protected] Upgrade AGP version in tracing_tests (flutter/flutter#134671) 2023-09-20 [email protected] Cover cupertino/form_section_test with leak tracing (flutter/flutter#135158) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#7 (flutter/flutter#134943) 2023-09-20 [email protected] Enable strict-inference (flutter/flutter#135043) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#10 (flutter/flutter#135143) 2023-09-20 [email protected] cover more tests with leak tracing (flutter/flutter#134833) 2023-09-20 [email protected] codeisn extension safe iOS framework (flutter/flutter#134966) 2023-09-20 [email protected] Roll Flutter Engine from 6f256257b79f to 55314d08d792 (2 revisions) (flutter/flutter#135151) 2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments in widgets library (flutter/flutter#134992) 2023-09-20 [email protected] Roll Flutter Engine from 5f82fc2f6f24 to 6f256257b79f (1 revision) (flutter/flutter#135147) 2023-09-20 [email protected] [Android] Add Java/AGP/Gradle incompatibility warning to `flutter create` (flutter/flutter#131444) 2023-09-20 [email protected] Roll Packages from d4e2454 to 51e74b9 (12 revisions) (flutter/flutter#135145) 2023-09-20 [email protected] Remove 'must not be null' comments from various libraries. (flutter/flutter#134984) 2023-09-20 [email protected] Roll Flutter Engine from 6535421b30d3 to 5f82fc2f6f24 (2 revisions) (flutter/flutter#135142) 2023-09-20 [email protected] Roll Flutter Engine from 67d4aaef3c7b to 6535421b30d3 (1 revision) (flutter/flutter#135139) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#8 (flutter/flutter#135045) 2023-09-20 [email protected] Cover more test/widgets tests with leak tracking flutter#9 (flutter/flutter#135054) 2023-09-20 [email protected] Roll Flutter Engine from 83b4df415bf3 to 67d4aaef3c7b (1 revision) (flutter/flutter#135128) 2023-09-20 [email protected] Roll Flutter Engine from df4e6c079682 to 83b4df415bf3 (2 revisions) (flutter/flutter#135102) 2023-09-20 [email protected] Roll Flutter Engine from 9c6b2500282b to df4e6c079682 (1 revision) (flutter/flutter#135101) 2023-09-20 [email protected] Roll Flutter Engine from 24f7ac38dfa2 to 9c6b2500282b (3 revisions) (flutter/flutter#135098) 2023-09-20 [email protected] Roll Flutter Engine from 36379b62bec8 to 24f7ac38dfa2 (2 revisions) (flutter/flutter#135096) 2023-09-20 [email protected] Roll Flutter Engine from 81b93fc4a2cc to 36379b62bec8 (2 revisions) (flutter/flutter#135095) 2023-09-20 [email protected] Roll Flutter Engine from 5a924a9017d7 to 81b93fc4a2cc (2 revisions) (flutter/flutter#135093) 2023-09-20 [email protected] Remove 'must be non-null' and 'must not be null' comments from material. (flutter/flutter#134991) 2023-09-20 [email protected] Unpin url launcher (remake) (flutter/flutter#134958) 2023-09-20 [email protected] Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (flutter/flutter#135085) 2023-09-20 [email protected] Manual roll Flutter Engine from a7af55c56aa6 to 0d7db40c27fd (7 revisions) (flutter/flutter#135079) 2023-09-20 [email protected] Remove 'must not be null' comments from painting and rendering libraries. (flutter/flutter#134993) 2023-09-20 [email protected] cover more tests with leak tracking (flutter/flutter#134837) 2023-09-20 [email protected] [flutter roll] Revert "Native assets support for Linux" (flutter/flutter#135069) 2023-09-20 [email protected] Manual roll Flutter Engine from 10c480310926 to a7af55c56aa6 (4 revisions) (flutter/flutter#135071) 2023-09-19 [email protected] Retry Linux web tests 1 time on roll presubmit (flutter/flutter#135073) 2023-09-19 [email protected] [web] Encode AssetManifest.bin as JSON and use that on the web. (flutter/flutter#131382) 2023-09-19 [email protected] Specify suggested format in doc comment. (flutter/flutter#134887) 2023-09-19 [email protected] Manual roll Flutter Engine from 28f14e6eec4f to 10c480310926 (6 revisions) (flutter/flutter#135066) ...
stuartmorgan-g
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by
flutter_toolin support of flutter/flutter#23164Note that it requires an as-of-yet unreleased Dart SDK - specifically needs dart-lang/sdk@6e23c3b (which had a few follow-up fixes for non-macOS platforms that were fully resolved by dart-lang/sdk@055ce6f).
/cc @GaryQian - I think you mentioned something about wanting to extend this for Android. One option might be to flesh out the server side of this and do it all in Dart.