Skip to content

[file_selector_android] Use Espresso 4.0 #7159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

[file_selector_android] Use Espresso 4.0 #7159

merged 1 commit into from
Jul 18, 2024
+1 −1

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jul 18, 2024 •
edited
Loading

Update espresso dependency

I think this is changelog exempt since I am not intending the change to teach/show anything to consumers of the app and it is an example only change. The main reason is to make sure that the 4.0 version of espresso is used in flutter owned code (and to see if the tests fail)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from gmackall as a code owner July 18, 2024 14:27
@reidbaker reidbaker requested a review from stuartmorgan-g July 18, 2024 17:55
stuartmorgan-g
stuartmorgan-g approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g
Copy link
Collaborator

I think this is changelog exempt

Even the bot agreed :)

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 18, 2024
@auto-submit auto-submit bot merged commit 976dfce into flutter:main Jul 18, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
976dfce [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)
cad04d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
976dfce [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)
57a55ba
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
Roll Packages from c7f0526 to 3144ac0 (8 revisions) (#152044)
20242d0 
flutter/packages@c7f0526...3144ac0

2024-07-19 [email protected] [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 [email protected] [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 [email protected] [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 [email protected] [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 [email protected] [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 [email protected] [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 25, 2024
Merged
11 tasks
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from c7f0526 to 3144ac0 (8 revisions) (flutter#152044)
fb21ebe 
flutter/packages@c7f0526...3144ac0

2024-07-19 [email protected] [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 [email protected] [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 [email protected] [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 [email protected] [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 [email protected] [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 [email protected] [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from c7f0526 to 3144ac0 (8 revisions) (flutter#152044)
3e87673 
flutter/packages@c7f0526...3144ac0

2024-07-19 [email protected] [in_app_purchase_storekit] Migrate FIATransactionCacheTests.m to.Swift (flutter/packages#7172)
2024-07-18 [email protected] [rfw][ci] Skip failing rfw golden tests (flutter/packages#7170)
2024-07-18 [email protected] [go_router] docs: fix flutter run command for Stateful Nested Navigation (flutter/packages#7158)
2024-07-18 [email protected] [in_app_purchase_storekit] Migrate FIAPPaymentQueueDeleteTests.m to.Swift (flutter/packages#7171)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.2 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#5704)
2024-07-18 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6668)
2024-07-18 [email protected] [shared_preferences] Platform interface for new shared preferences async (flutter/packages#6962)
2024-07-18 [email protected] [file_selector_android] Use Espresso 4.0 (flutter/packages#7159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gmackall gmackall Awaiting requested review from gmackall

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: file_selector platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reidbaker @stuartmorgan-g