-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[tool] Adds --wasm
flag to the drive-examples
command
#7162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tool] Adds --wasm
flag to the drive-examples
command
#7162
Conversation
Currently we have a 1:! correspondence with |
@stuartmorgan How about this? |
drive-examples
with the web-wasm
platform--wasm
flag to the drive-examples
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the web args to drive
, so @ditman should check that part, but structurally this all LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--wasm --web-renderer=canvaskit
is some times useful, but not that much for app developers (@eyebrowsoffire said), so this LGTM! Let's land it so we can look at it in the maps migration PR! :)
Do you have any insight on what this combination does? Does it compile the WASM version but run the canvaskit one? |
It compiles the dart code to webassembly but uses the canvaskit renderer. By default, |
flutter/packages@19daf6f...3d358d9 2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@19daf6f...3d358d9 2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@19daf6f...3d358d9 2024-07-26 [email protected] [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 [email protected] [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 [email protected] [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 [email protected] [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I was unsure if we wanted to add a new platform option for this or add a
--wasm
flag to the command. Adding a--wasm
flag seems more complicated since we would probably want to add extra handling around proper use of the flag, whereas adding aweb-wasm
platform should require no additional checks.This is in preparation for flutter/flutter#151664