Skip to content

[in_app_purchase_storekit] convert paymentQueueTests to swift #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2024
Merged

[in_app_purchase_storekit] convert paymentQueueTests to swift #7204

merged 5 commits into from
Jul 24, 2024

Conversation

LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Jul 23, 2024 •
edited
Loading

Part of flutter/flutter#151624

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@LouiseHsu LouiseHsu changed the title init [in_app_purchase_storekit] convert paymentQueueTests to swift Jul 23, 2024
@LouiseHsu LouiseHsu marked this pull request as ready for review July 23, 2024 23:03
@LouiseHsu LouiseHsu requested a review from hellohuanlin July 23, 2024 23:03
hellohuanlin
hellohuanlin approved these changes Jul 24, 2024
View reviewed changes
.../in_app_purchase/in_app_purchase_storekit/example/shared/RunnerTests/PaymentQueueTests.swift Outdated
var periodMap: [String: Any] = [:]
var discountMap: [String: Any] = [:]
var productMap: [String: Any] = [:]
var productResponseMap: [String: Any] = [:]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can just use getters for these:

private var periodMap: [String: Any] {
  ["numberOfUnits": 0, "unit": 0]
}

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
@auto-submit auto-submit bot merged commit 1c319ac into flutter:main Jul 24, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
1c319ac [in_app_purchase_storekit] convert paymentQueueTests to swift (…
61c5e22 
…flutter/packages#7204)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
Roll Packages from e978e06 to 1c319ac (4 revisions) (#152238)
0d50491 
flutter/packages@e978e06...1c319ac

2024-07-24 [email protected] [in_app_purchase_storekit] convert paymentQueueTests to swift (flutter/packages#7204)
2024-07-23 [email protected] Roll Flutter (stable) from 761747b to b0850be (6 revisions) (flutter/packages#7175)
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7188)
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 25, 2024
Merged
11 tasks
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from e978e06 to 1c319ac (4 revisions) (flutter#152238)
dd795c9 
flutter/packages@e978e06...1c319ac

2024-07-24 [email protected] [in_app_purchase_storekit] convert paymentQueueTests to swift (flutter/packages#7204)
2024-07-23 [email protected] Roll Flutter (stable) from 761747b to b0850be (6 revisions) (flutter/packages#7175)
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7188)
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LouiseHsu LouiseHsu mentioned this pull request Aug 8, 2024
Closed
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from e978e06 to 1c319ac (4 revisions) (flutter#152238)
7b3acbf 
flutter/packages@e978e06...1c319ac

2024-07-24 [email protected] [in_app_purchase_storekit] convert paymentQueueTests to swift (flutter/packages#7204)
2024-07-23 [email protected] Roll Flutter (stable) from 761747b to b0850be (6 revisions) (flutter/packages#7175)
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7188)
2024-07-22 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LouiseHsu @hellohuanlin