[web_benchmarks] Refactor the test benchmark app to make the example easier to follow #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
approved these changes
Sep 12, 2024
packages/web_benchmarks/testing/test_app/benchmark/test_infra/automator.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 13, 2024
flutter/packages@91caa7a...330581f 2024-09-12 [email protected] Refactor the test benchmark app to make the example easier to follow (flutter/packages#7640) 2024-09-12 [email protected] Fix an if statement with resumed video players on Android. (flutter/packages#7641) 2024-09-12 [email protected] Roll Flutter from 2e221e7 to 303f222 (77 revisions) (flutter/packages#7638) 2024-09-12 [email protected] [google_maps_flutter_android] Convert `PlatformCameraUpdate` to pigeon. (flutter/packages#7507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kenzieschmoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change to this package will follow that changes the structure of setting the initial path for the benchmark run. This was originally done in #7632, which was closed because there were more changes needed to get the tests to pass. This cleanup is part of that work.
This PR
test_app/benchmarkfollowing pub package guidance for naming conventionsflutter createto ensure the web configuration is up to date