Skip to content

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Sep 18, 2024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title Ima android adsrendering [interactive_media_ads] Adds internal wrapper for Android native AdsRenderingSettings Sep 18, 2024
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2024
@auto-submit auto-submit bot merged commit e9253e6 into flutter:main Sep 18, 2024
76 checks passed
@bparrishMines bparrishMines deleted the ima_android_adsrendering branch September 18, 2024 18:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 19, 2024
flutter/packages@c7406b3...d83d021

2024-09-19 [email protected] Manual roll Flutter from c4c9f47 to 7fe8237 (14 revisions) (flutter/packages#7663)
2024-09-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdsRenderingSettings` (flutter/packages#7660)
2024-09-18 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.34.0 to 3.35.0 in /packages/interactive_media_ads/android (flutter/packages#7562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
flutter/packages@c7406b3...d83d021

2024-09-19 [email protected] Manual roll Flutter from c4c9f47 to 7fe8237 (14 revisions) (flutter/packages#7663)
2024-09-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdsRenderingSettings` (flutter/packages#7660)
2024-09-18 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.34.0 to 3.35.0 in /packages/interactive_media_ads/android (flutter/packages#7562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
flutter/packages@c7406b3...d83d021

2024-09-19 [email protected] Manual roll Flutter from c4c9f47 to 7fe8237 (14 revisions) (flutter/packages#7663)
2024-09-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdsRenderingSettings` (flutter/packages#7660)
2024-09-18 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.34.0 to 3.35.0 in /packages/interactive_media_ads/android (flutter/packages#7562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 27, 2024
flutter/packages@c7406b3...d83d021

2024-09-19 [email protected] Manual roll Flutter from c4c9f47 to 7fe8237 (14 revisions) (flutter/packages#7663)
2024-09-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdsRenderingSettings` (flutter/packages#7660)
2024-09-18 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.34.0 to 3.35.0 in /packages/interactive_media_ads/android (flutter/packages#7562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 27, 2024
flutter/packages@c7406b3...d83d021

2024-09-19 [email protected] Manual roll Flutter from c4c9f47 to 7fe8237 (14 revisions) (flutter/packages#7663)
2024-09-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdsRenderingSettings` (flutter/packages#7660)
2024-09-18 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.34.0 to 3.35.0 in /packages/interactive_media_ads/android (flutter/packages#7562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants