This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[google_maps_flutter] Allow (de-)serialization of CameraPosition #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change looks good. Can you update the pubspec and changelog? Thanks! |
…-cameraPosition-json # Conflicts: # packages/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/pubspec.yaml
@duzenko I was busy with some issues in the past couple of weeks. Let me know if you get a change to fix the merge conflicts and we can merge this. |
This comment has been minimized.
This comment has been minimized.
…on-json # Conflicts: # packages/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/pubspec.yaml
This comment has been minimized.
This comment has been minimized.
Now that marker drag events is in. Can you please rebase? |
…on-json # Conflicts: # packages/google_maps_flutter/CHANGELOG.md
This comment has been minimized.
This comment has been minimized.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…tter#1784) * Allow (de-)serialization of CameraPosition * Camera position toMap use fixes * Updated the pubspec and changelog
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Add macos to CI * Add lint script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make CameraPosition.toMap public and change visibility of CameraPosition fromMap.
Intended use:
Related Issues
Fixes flutter/flutter#34321
Checklist
Presumably none needed
Impossible: [flutter_plugin_tools] 'format' crashes on Windows flutter#33964
///
).None found
flutter analyze
) does not report any problems on my PR.Pending review
Pending review
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?