[camera] Add support for Torch and Auto Exposure (#19845) #1969

NeKoFu · 2019-08-11T01:09:10Z

Description

Add new callable methods torchOn and torchOff
Add new callable methods aeOn and aeOff
Torch and AE mode could be activated at initialize

Related Issues

Camera flash functionality during image and/or video capture #19845
Future of the Camera Plugin (Refactor/Rework) #31225

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

* new callable methods torchOn and torchOff * new callable methods aeOn and aeOff * Torch and AE mode could be activated at initialize

… Exposure settings

NeKoFu · 2019-08-11T12:29:41Z

To reviewers, sorry for the quantity of commits to review. I don't have a macbook to validate the iOS part and flutter_plugin_tools doesn't works on my windows. I used the CI to fix iOS code and code format. This feature works pretty well on android so I hope it will works also without any issues on iOS.

mklim

Thank you for your contribution! I didn't thoroughly review the whole PR, but I gave this an initial pass with some first feedback. Thanks for the heads up about the iOS part needing additional testing and for doing as much as you could.

I'm following the initial PR review policy.I'm labeling this with "backlog" for now because this PR isn't trivial to review. We'll prioritize reviewing it according to the issue's priority.

Relevant issues:
flutter/flutter#19845

packages/camera/CHANGELOG.md

packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java

packages/camera/lib/camera.dart

NeKoFu · 2019-10-08T21:57:56Z

@mikerockett, thanks for your feedbacks. The flash turns on momentarily because the auto exposure mode is set to CONTROL_AE_MODE_ON_ALWAYS_FLASH. With this mode, auto exposure controls the flash and use it once immediately to adjust colors and light. Without this AE setting, I have no flash at all when I take a picture. It simply doesn't works on my phone without this AE mode and I have tested a lot of combinations. 😞

I also saw one mistake with the continuous autofocus mode so I have fixed it.

For now, I finally have an old macbook so I can work on the iOS version more easily. 😋

malikdoksoz · 2019-10-08T22:03:08Z

@mikerockett, thanks for your feedbacks. The flash turns on momentarily because the auto exposure mode is set to CONTROL_AE_MODE_ON_ALWAYS_FLASH. With this mode, auto exposure controls the flash and use it once immediately to adjust colors and light. Without this AE setting, I have no flash at all when I take a picture. It simply doesn't works on my phone without this AE mode and I have tested a lot of combinations. 😞

I also saw one mistake with the continuous autofocus mode so I have fixed it.

For now, I finally have an old macbook so I can work on the iOS version more easily. 😋

I tried iPhone 6-7-8( and plus) with iOS 12 and 13. It's working no problem :) I'm using this repo https://gitlab.com/mikerockett/flutter-camera . Can you give me recently updated repo (git link)

…ter-master # Conflicts: # packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java # packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java

# Conflicts: # packages/camera/CHANGELOG.md # packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java # packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java # packages/camera/pubspec.yaml

mikerockett · 2019-11-04T06:36:15Z

@NeKoFu – You’re most welcome. I do understand it can be quite difficult to get the right combination; I battled with this myself, which was extraordinarily frustrating given that I have very limited knowledge of how it all works. Thanks for working so hard on this.

@malikdoksoz – my repo is out of date, given the changes made here. I'm not going to be updating the repo at this point, as there is a commercial app in circulation that relies on it, and the flash behaviour used (always on / always off) is perfect for our needs at the moment.

jovinho · 2019-11-12T17:45:41Z

Any idea when this feature is gonna be merged into master?

JoseGeorges8

I've forked the camera plugin and applied your PR changes and tested them out. The android code seems to be working fine, however your iOS implementation is broken.

I don't have much experience with Objective C code but I got it to work by doing some changes.

Essentially on the handleMethodCallAsync you're checking for the invoking methods "flashOn" and "flashOff" but the method you really added was "setFlash", so there's really no bridge to access those methods from the dart code.

I've changed the code and got it running with a couple file changes.

Notice the changes I've done are molded towards my team needs:

in the Camera.java file:

  public  void turnFlashOn(@NonNull final Result result){
    setFlash(result, 3);
  }

  public  void turnFlashOff(@NonNull final Result result){
    setFlash(result, 0);

  }

in the MethodCallHandlerImpl.java:

      case "turnFlashOn":
      {	      
        camera.turnFlashOn(result);
        break;
      }
      case "turnFlashOff":
      {
        camera.turnFlashOff(result);
        break;	       
      }

in the CameraPlugin.m:

} else if ([@"turnFlashOn" isEqualToString:call.method]) {
  [_camera setFlashMode:true];
  result(nil);
} else if ([@"turnFlashOff" isEqualToString:call.method]) {
   [_camera setFlashMode:false];
   result(nil);
}

lastly in the camera.dart :

/// Turn flash light off
  /// See [FlashMode] enum for available options
  Future<void> turnFlashOff() async {
    if (!value.isInitialized || _isDisposed) {
      throw CameraException(
        'Uninitialized CameraController.',
        'flashMode was called on uninitialized CameraController',
      );
    }
    try {
      await _channel.invokeMethod<void>('turnFlashOff');
    } on PlatformException catch (e) {
      throw CameraException(e.code, e.message);
    }
  }

  /// Turn flash light on
  /// See [FlashMode] enum for available options
  Future<void> turnFlashOn() async {
    if (!value.isInitialized || _isDisposed) {
      throw CameraException(
        'Uninitialized CameraController.',
        'flashMode was called on uninitialized CameraController',
      );
    }
    try {
      await _channel.invokeMethod<void>('turnFlashOn');
    } on PlatformException catch (e) {
      throw CameraException(e.code, e.message);
    }
 }

ghunkins · 2019-12-11T01:12:28Z

Echoing @LeonardoDavila, this is a high priority feature for many ongoing initiatives. Can this feature be prioritized? It seems as though only small tweaks and a re-base are necessary.

gisinator · 2020-01-03T22:49:21Z

Cant wait for a working flash solution :)

Ahmadre · 2020-01-04T19:54:19Z

@NeKoFu any updates?

jovinho · 2020-01-08T20:36:18Z

Is this code working for android and ios? Can i copy it?

NeKoFu · 2020-01-13T08:06:23Z

Hi everyone, I was very busy at the end of the year but I didn't forgot this package. At my company, I work now to porting our application to iOS and obviously, I need to finish the iOS part of this feature.

I come back very soon with an update.

malikdoksoz · 2020-02-12T22:01:15Z

Can you give us time to finish? Lack of flash is a big problem. Thank you

felipebueno · 2020-03-11T19:33:45Z

Hi, @NeKoFu!

Do you have any updates on this PR?

It's been 2 months since your last reply. We really need the flash feature ASAP 😄

GustavoFigueira · 2020-03-19T16:51:40Z

Hi @NeKoFu!

Would be great to have this feature incorporated soon! My company needs tha flash function in our camera app.

Thanks in advance.

Conflicts: packages/camera/CHANGELOG.md packages/camera/lib/camera.dart packages/camera/pubspec.yaml packages/google_sign_in/lib/google_sign_in.dart packages/google_sign_in/pubspec.yaml

orestesgaolin · 2020-04-08T15:43:33Z

It seems like the title of the PR should include Auto Focus not Auto Exposure

orestesgaolin · 2020-04-08T16:07:21Z

packages/camera/lib/camera.dart

+
+    try {
+      await _channel.invokeMethod<void>(
+          'setAutoFocus', <String, dynamic>{'mode': mode.index});


This method is called setAutoExposureMode:enableAutoExposure in iOS project

piotrek1543 · 2020-04-27T09:56:05Z

It seems like the title of the PR should include Auto Focus not Auto Exposure

The name is right according to this commit (sorry I am noob in iOS): 1d8d34a

malikdoksoz · 2020-05-13T16:45:15Z

@NeKoFu When will I be able to use this?

acoutts · 2020-06-18T16:18:17Z

I just tried this out - it seems it is broken in iOS and a bit buggy:

If you toggle the flash button it will eventually turn the torch on, but toggling the button again to flash off won't disable the torch unless you tap the torch button twice.
When on the auto setting and the flash is turned on, it never turns off unless you again toggle the torch button twice.
iOS is not working. Another issue is I see you are setting the torch setting on AVCaptureDevice *device = [AVCaptureDevice defaultDeviceWithMediaType:AVMediaTypeVideo]; and not using the actual active camera in use.
Why is google sign on included in the PR?
The dart code calls a method named setFlash on the platform channel but this isn't implemented on iOS, iOS only has explicit cases like flashOn, flashOff which is probably why it's broken in iOS.
Throughout the code there are conflicting uses of the words auto exposure and auto focus, which are two very different functions of a camera.

I made a new PR before finding this one where I only implemented torch mode. It is working in iOS and Android and works with photos/video recording. I suggest anyone who needs the torch functionality now please try mine here: #2837

mvanbeusekom · 2021-01-07T10:42:12Z

closing as duplicate of #3338 and #3346

NeKoFu and others added 20 commits August 8, 2019 02:27

[camera] Add support for Torch and Auto Exposure

11966fa

* new callable methods torchOn and torchOff * new callable methods aeOn and aeOff * Torch and AE mode could be activated at initialize

[camera] set auto exposure trigger when turn on or off the torch

841d3f3

[camera] increment version in pubspec.yaml

77fffa0

[camera] update changelog

2680f8d

Merge branch 'master' into camera_torch

8afa990

[camera] fix format for default value

ab961e9

Merge branch 'camera_torch' of https://github.com/NeKoFu/plugins.git

3e284a9

[camera] remove commented code and fix format

664f566

[camera] fix format

cf1986d

[camera] fix space characters

9301cab

[camera] fix format

f5566ac

[camera] delete a blank line for the pleasure of the CI

1111074

[camera] refactor ios code

21f1ddf

[camera] fix ios code format

de89946

[camera] fix ios code

d2b876f

[camera] delete a blank line for the pleasure of the CI

4c18d55

[camera] fix iOS mistakes like default value for the setTorchMode and…

6d4ef41

… Exposure settings

[camera] resolve merge conflit

81d35ae

[camera] fix iOS code

dd8f6f3

[camera] Merge branch 'camera_torch'

02d9b40

NeKoFu requested review from bparrishMines and mklim as code owners August 11, 2019 01:09

googlebot added the cla: yes label Aug 11, 2019

NeKoFu added 4 commits August 11, 2019 03:41

[camera] fix enum to choose Exposure

1d8d34a

[camera] fix float casting in iOS code

5b622cf

[camera] Update example

05adac8

[camera] Fix format

4605961

mklim self-assigned this Aug 12, 2019

mklim reviewed Aug 13, 2019

View reviewed changes

Merge branch 'camera_torch' of https://github.com/NeKoFu/plugins.git

0dccb8e

iapicca mentioned this pull request Nov 1, 2019

Camera Flash On and Off flutter/flutter#43924

Closed

NeKoFu added 4 commits November 3, 2019 17:27

Merge branch 'master' of https://github.com/flutter/plugins into flut…

fccf0f2

…ter-master # Conflicts: # packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java # packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java

Merge branch 'flutter-master'

51e7ca6

Merge branch 'master' into camera_torch

16d5689

# Conflicts: # packages/camera/CHANGELOG.md # packages/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java # packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java # packages/camera/pubspec.yaml

Merge fix

316869a

JoseGeorges8 approved these changes Dec 6, 2019

View reviewed changes

JoseGeorges8 suggested changes Dec 10, 2019

View reviewed changes

GustavoFigueira approved these changes Mar 19, 2020

View reviewed changes

Merge commit 'fc45624236b8789ea2fc776a7b254cd16e9dc926'

47aedeb

Conflicts: packages/camera/CHANGELOG.md packages/camera/lib/camera.dart packages/camera/pubspec.yaml packages/google_sign_in/lib/google_sign_in.dart packages/google_sign_in/pubspec.yaml

orestesgaolin reviewed Apr 8, 2020

View reviewed changes

ghunkins mentioned this pull request Jul 7, 2020

[camera] Added support for flash/torch mode in iOS and Android #2837

Closed

13 tasks

mvanbeusekom closed this Jan 7, 2021

[camera] Add support for Torch and Auto Exposure (#19845) #1969

[camera] Add support for Torch and Auto Exposure (#19845) #1969

Uh oh!

Conversation

NeKoFu commented Aug 11, 2019

Description

Related Issues

Checklist

Breaking Change

Uh oh!

NeKoFu commented Aug 11, 2019

Uh oh!

mklim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NeKoFu commented Oct 8, 2019

Uh oh!

malikdoksoz commented Oct 8, 2019

Uh oh!

mikerockett commented Nov 4, 2019

Uh oh!

jovinho commented Nov 12, 2019

Uh oh!

JoseGeorges8 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Notice the changes I've done are molded towards my team needs:

Uh oh!

ghunkins commented Dec 11, 2019

Uh oh!

gisinator commented Jan 3, 2020

Uh oh!

Ahmadre commented Jan 4, 2020

Uh oh!

jovinho commented Jan 8, 2020

Uh oh!

NeKoFu commented Jan 13, 2020

Uh oh!

malikdoksoz commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felipebueno commented Mar 11, 2020

Uh oh!

GustavoFigueira commented Mar 19, 2020

Uh oh!

orestesgaolin commented Apr 8, 2020

Uh oh!

orestesgaolin Apr 8, 2020

Choose a reason for hiding this comment

Uh oh!

piotrek1543 commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

malikdoksoz commented May 13, 2020

Uh oh!

acoutts commented Jun 18, 2020

Uh oh!

mvanbeusekom commented Jan 7, 2021

Uh oh!

Uh oh!

JoseGeorges8 left a comment •

edited

Loading

malikdoksoz commented Feb 12, 2020 •

edited

Loading

piotrek1543 commented Apr 27, 2020 •

edited

Loading