This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_auth] fetchSignInMethodsForEmail returns null on iOS, empty array on Android #2002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the issue I opened in the firebase sdk repo explains, a call to
fetchProvidersForEmail()�
in the native Firebase Auth SDKs for an unregistered user returns null on iOS, and an empty array on Android-so the plugin returns different results for the same line of Dart code depending on the platform.The best option would be to standardize the native SDKs, but until that happens I'm proposing a slight change that returns an empty array on iOS if the SDK returns null.
This can't be tested without an integration test, and the firebase_auth library doesn't have any yet.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?