Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] fetchSignInMethodsForEmail returns null on iOS, empty array on Android #2002

Closed
wants to merge 3 commits into from
Closed

Conversation

timtraversy
Copy link
Contributor

Description

As the issue I opened in the firebase sdk repo explains, a call to fetchProvidersForEmail()� in the native Firebase Auth SDKs for an unregistered user returns null on iOS, and an empty array on Android-so the plugin returns different results for the same line of Dart code depending on the platform.
The best option would be to standardize the native SDKs, but until that happens I'm proposing a slight change that returns an empty array on iOS if the SDK returns null.

This can't be tested without an integration test, and the firebase_auth library doesn't have any yet.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@collinjackson
Copy link
Contributor

This PR has been migrated to the new repo. See firebase/flutterfire#26

collinjackson added a commit to collinjackson/flutterfire that referenced this pull request Aug 26, 2019
kroikie added a commit to firebase/flutterfire that referenced this pull request Aug 30, 2019
[firebase_auth] Consistent platform behavior for fetchSignInMethodsForEmail
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants