[google_maps_flutter] Add liteModeEnabled option #2449

otopba · 2020-01-07T23:21:19Z

Description

Add liteModeEnabled option

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

Update master

Update from master

Update master

update master

Update master

This reverts commit e038a3e

cyanglaz

LGTM!
Thanks, this is great. I left a few nits.

cyanglaz · 2020-01-21T22:14:32Z

packages/google_maps_flutter/lib/src/google_map.dart

@@ -91,6 +92,9 @@ class GoogleMap extends StatefulWidget {
  /// True if the map view should respond to zoom gestures.
  final bool zoomGesturesEnabled;

+  /// True if the map view should be in lite mode. Android only. See https://developers.google.com/maps/documentation/android-sdk/lite#overview_of_lite_mode for more details.


nits: The See.. should be at its own paragraph.

/// True if the map view should be in lite mode. Android only. /// /// See https://developers.google.com/maps/documentation/android-sdk/lite#overview_of_lite_mode for more details.

cyanglaz · 2020-01-21T22:16:37Z

packages/google_maps_flutter/lib/src/google_map.dart

@@ -472,6 +480,10 @@ class _GoogleMapOptions {
    addIfNonNull('scrollGesturesEnabled', scrollGesturesEnabled);
    addIfNonNull('tiltGesturesEnabled', tiltGesturesEnabled);
    addIfNonNull('zoomGesturesEnabled', zoomGesturesEnabled);
+    addIfNonNull('liteModeEnabled', liteModeEnabled);
+    if (liteModeEnabled != null && liteModeEnabled && !Platform.isAndroid) {
+      print('Warning: liteModeEnabled is Android only');


Instead of printing a warning message, what do you think about adding an assert(with warning message) here so developers can encounter a crash in debug mode. This way we are sure the developers know that this is android only.

Thus if developers knows about this behaviour and consciously want to use maps on Android with enabled light mode and disabled on iOS they should write platform specific code in their app to avoid crashes in debug mode.

Something like this:

Map( liteModeEnabled: Platform.isAndroid, );

Is this the right approach to working with plugins?

+1 @sanekyy

amirh · 2020-01-21T22:58:53Z

@otopba I'm assuming you're adding this feature as you want to use it in your app. I'm curious what is your plan for iOS ?

(I'm mainly asking to augment the discussion around what to do with this parameter on iOS)

otopba · 2020-02-12T04:58:20Z

@ramsestom
"The Maps SDK for Android can serve a bitmap image of a map, offering limited interactivity to the user. This is called a lite mode map."

You are not right. It is very lite view

https://developers.google.com/maps/documentation/android-sdk/lite

# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

otopba · 2020-02-24T19:44:13Z

@amirh Hi! Could you merge this PR?

# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

blasten · 2020-05-15T02:20:40Z

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

+  }) {
+    assert(liteModeEnabled == null ||
+        !liteModeEnabled ||
+        (liteModeEnabled && Platform.isAndroid));


nit: what about leaving this as a noop if !Platform.isAndroid?

I think we can leave it as is, an assertion helps the user to be more explicit when using liteMode so they are aware it doesn't work on iOS.

blasten · 2020-05-15T02:21:16Z

@cyanglaz is there anything else left in this PR?

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart

cyanglaz

Let's rebase this and try to land it. @otopba We also need to add this param in the platform interface, do you want to do that too?

otopba · 2020-05-15T16:54:51Z

@cyanglaz Ok. I will make it. I waiting for landing about half of year 🤓

# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java # packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart # packages/google_maps_flutter/google_maps_flutter/example/test_driver/google_map_inspector.dart # packages/google_maps_flutter/google_maps_flutter/example/test_driver/google_maps_e2e.dart # packages/google_maps_flutter/google_maps_flutter/pubspec.yaml # packages/google_maps_flutter/google_maps_flutter/test/fake_maps_controllers.dart

otopba · 2020-05-15T20:05:29Z

@cyanglaz
@blasten
Done

cyanglaz

LGTM

…-player-plugin-fix * commit '25a585dfeef6d2dc224fd0dddee327372de63782': [image_picker] iOS: fix bug, sometimes double click cancel button will crash (flutter#2625) [google_maps_flutter] Add liteModeEnabled option (flutter#2449) Update README.md (flutter#2768) [url_launcher_web] Launch mailto urls in same window in Safari (flutter#2740) update README with enableJavaScript info (flutter#2766) Run publish ci check on master (flutter#2764) [image_picker] Add documentation for Android external storage permissions (flutter#2765)

ditman · 2020-05-26T22:00:51Z

I created a follow-up PR to this one, here: #2798

otopba added 16 commits July 26, 2019 15:23

Merge pull request #1 from flutter/master

073fca5

Update master

Merge pull request #2 from flutter/master

bb12418

Update master

Merge pull request #3 from flutter/master

a03ee88

Update from master

Merge pull request #4 from flutter/master

e2613e0

Update master

Merge pull request #5 from flutter/master

1c98d10

Update master

Merge pull request #6 from flutter/master

b50c88e

Update master

Merge pull request #7 from flutter/master

ce695b1

Update master

Merge pull request #8 from flutter/master

58192f4

Update master

Merge pull request #9 from flutter/master

485a419

Update master

Merge pull request #10 from flutter/master

dde8df7

update master

Merge pull request #11 from flutter/master

33ed689

Update master

Merge remote-tracking branch 'upstream/master'

7ec3707

Merge remote-tracking branch 'upstream/master'

f056c49

Merge remote-tracking branch 'upstream/master'

ab1d5bc

Merge remote-tracking branch 'upstream/master'

e4a6011

Add liteModeEnabled option

6d8f634

otopba requested a review from iskakaushik as a code owner January 7, 2020 23:21

googlebot added the cla: yes label Jan 7, 2020

otopba mentioned this pull request Jan 14, 2020

Pull request Ignoring flutter/flutter#48814

Closed

Merge remote-tracking branch 'upstream/master'

fb15656

otopba requested a review from cyanglaz January 19, 2020 13:30

otopba added 6 commits January 22, 2020 00:18

Merge remote-tracking branch 'upstream/master'

596184c

Add dummy map initialization

e038a3e

Revert "Add dummy map initialization"

4345ed5

This reverts commit e038a3e

Merge branch 'master' into liteModeEnabled

2d0abd4

format

7d9a2ac

format

b4a4989

sanekyy approved these changes Jan 21, 2020

View reviewed changes

cyanglaz reviewed Jan 21, 2020

View reviewed changes

otopba added 4 commits February 24, 2020 21:11

Merge remote-tracking branch 'upstream/master'

c267dca

Merge branch 'master' into liteModeEnabled

d6c7eb0

# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

merge

56b897d

move file

454faa7

otopba added 4 commits March 19, 2020 23:26

Merge remote-tracking branch 'upstream/master'

4816227

Merge remote-tracking branch 'upstream/master'

bb4e5be

Merge branch 'master' into liteModeEnabled

5862774

# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

merge

bf0e39e

otopba requested a review from cyanglaz March 22, 2020 19:19

iskakaushik removed their request for review April 28, 2020 16:37

Merge remote-tracking branch 'upstream/master'

0a86ebc

blasten reviewed May 15, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master'

6cd64da

cyanglaz reviewed May 15, 2020

View reviewed changes

packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart Show resolved Hide resolved

cyanglaz suggested changes May 15, 2020

View reviewed changes

otopba added 2 commits May 15, 2020 19:56

fix example

696468f

cyanglaz approved these changes May 19, 2020

View reviewed changes

cyanglaz merged commit 82f8f49 into flutter:master May 19, 2020

ditman mentioned this pull request May 26, 2020

[google_maps_flutter] Move test to its correct location. #2798

Merged

12 tasks

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020

[google_maps_flutter] Add liteModeEnabled option (flutter#2449)

0fc6893

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[google_maps_flutter] Add liteModeEnabled option (flutter#2449)

82cf1c4

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[google_maps_flutter] Add liteModeEnabled option (flutter#2449)

1d4fc8c

[google_maps_flutter] Add liteModeEnabled option #2449

[google_maps_flutter] Add liteModeEnabled option #2449

Uh oh!

Conversation

otopba commented Jan 7, 2020

Description

Checklist

Breaking Change

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

cyanglaz Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

otopba Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

cyanglaz Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

sanekyy Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

otopba Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

amirh commented Jan 21, 2020

Uh oh!

otopba commented Feb 12, 2020

Uh oh!

otopba commented Feb 24, 2020

Uh oh!

blasten May 15, 2020

Choose a reason for hiding this comment

Uh oh!

cyanglaz May 15, 2020

Choose a reason for hiding this comment

Uh oh!

blasten commented May 15, 2020

Uh oh!

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

otopba commented May 15, 2020

Uh oh!

otopba commented May 15, 2020

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented May 26, 2020

Uh oh!

Uh oh!