This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] supports v2 android embedding. #2488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
force-pushed
the
google_maps_v2
branch
from
175f502 to
b55eef7
Compare
cyanglaz
changed the title
collinjackson
approved these changes
Jan 30, 2020
Yes! Will update. |
collinjackson
approved these changes
Jan 30, 2020
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
13 tasks
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#41837
Modified some e2e tests as they were actually failing prior to this PR:
The android getMaxZoomLevel API in google map since unstable, updated the
updateMinMaxZoomLevelstest to use a different approach: set min-max preference and try to zoom to see if the camera can zoom beyond the boundary.Disabled all the location based tests. On Android, location apis are not accessible until granting permission. I am not sure if we have a way to grand permission on CI. /cc @collinjackson @amirh
Updated
testSetMapStyle invalid JSSON Stringto only check if it is failing rather than a specific error message. The error message returned from iOS and Android are different.