-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Add support for running Linux desktop tests on CI #2717
Conversation
- name: build-linux+drive-examples | ||
install_script: | ||
- flutter config --enable-linux-desktop | ||
build_script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we run the tests on stable, too?
Or it is in the future plan, can we add a TODO here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like web, stable isn't supported for Linux. I'll add a TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! CI seems failing
I'm assuming it's infra failure since it said the agent stopped responding. Trying a re-run, and will escalate to infra channel if it keeps failing. |
The failing web tests are using Chrome 81, while the passing master tests are using Chrome 79; my best guess at this point is that the web tests are broken with newer Chrome and my PR is hitting what is essentially submarine bustage because it's rebuilding the Docker image. |
@hterkelsen It looks like you added the code for this in #2307; is there a way we can structure this so that we control what version of Chrome we are using for e2e tests instead of random PRs touching the Dockerfile having the side-effect of updating Chrome? |
Landing with a modified approach that uses a separate Dockerfile and separate top-level task for the Linux desktop tests, so that progress on Linux isn't gated on the web issue. At some point when web tests work with the latest Chrome, or the Dockerfile is changed not to rely on a floating Chrome version, they could be re-combined. |
Adds support for building and driving e2e tests for Linux (as a target). flutter/flutter#55327
Adds support for building and driving e2e tests for Linux (as a target). flutter/flutter#55327
Adds support for building and driving e2e tests for Linux (as a target). flutter/flutter#55327
Description
Adds support for building and driving e2e tests for Linux (as a target).
Related Issues
flutter/flutter#55327
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?