Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Add support for running Linux desktop tests on CI #2717

Merged
merged 12 commits into from
May 6, 2020

Conversation

stuartmorgan-g
Copy link
Contributor

Description

Adds support for building and driving e2e tests for Linux (as a target).

Related Issues

flutter/flutter#55327

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@stuartmorgan-g stuartmorgan-g changed the title WIP: Linux CI support Add support for running Linux desktop tests on CI Apr 29, 2020
@stuartmorgan-g stuartmorgan-g requested a review from cyanglaz April 29, 2020 17:22
- name: build-linux+drive-examples
install_script:
- flutter config --enable-linux-desktop
build_script:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run the tests on stable, too?
Or it is in the future plan, can we add a TODO here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like web, stable isn't supported for Linux. I'll add a TODO.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI seems failing

@stuartmorgan-g
Copy link
Contributor Author

CI seems failing

I'm assuming it's infra failure since it said the agent stopped responding. Trying a re-run, and will escalate to infra channel if it keeps failing.

@stuartmorgan-g
Copy link
Contributor Author

The failing web tests are using Chrome 81, while the passing master tests are using Chrome 79; my best guess at this point is that the web tests are broken with newer Chrome and my PR is hitting what is essentially submarine bustage because it's rebuilding the Docker image.

@stuartmorgan-g
Copy link
Contributor Author

@hterkelsen It looks like you added the code for this in #2307; is there a way we can structure this so that we control what version of Chrome we are using for e2e tests instead of random PRs touching the Dockerfile having the side-effect of updating Chrome?

@stuartmorgan-g
Copy link
Contributor Author

Landing with a modified approach that uses a separate Dockerfile and separate top-level task for the Linux desktop tests, so that progress on Linux isn't gated on the web issue.

At some point when web tests work with the latest Chrome, or the Dockerfile is changed not to rely on a floating Chrome version, they could be re-combined.

@stuartmorgan-g stuartmorgan-g merged commit 1e18d72 into flutter:master May 6, 2020
@stuartmorgan-g stuartmorgan-g deleted the linux-ci branch May 6, 2020 16:14
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
Adds support for building and driving e2e tests for Linux (as a target).

flutter/flutter#55327
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Adds support for building and driving e2e tests for Linux (as a target).

flutter/flutter#55327
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Adds support for building and driving e2e tests for Linux (as a target).

flutter/flutter#55327
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants