Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Add web to example app. #2736

Merged
merged 3 commits into from
May 8, 2020

Conversation

ditman
Copy link
Member

@ditman ditman commented May 5, 2020

Description

Add web to the example app so users can do flutter run -d chrome there, and have the application run. This has been supported for a long time, but the example had never been modified to add web support until now.

Related Issues

n/a

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@ditman ditman requested review from mklim and harryterkelsen May 5, 2020 23:31
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman merged commit 2909502 into flutter:master May 8, 2020
@ditman ditman deleted the url-launcher-web-example branch May 8, 2020 18:05
stuartmorgan-g pushed a commit to stuartmorgan-g/plugins that referenced this pull request May 11, 2020
* Bump version and some metadata. Ignore generated_plugin_registrant.dart globally.
mgonzalezc pushed a commit to mgonzalezc/plugins that referenced this pull request May 19, 2020
* master: (96 commits)
  Update README.md (flutter#2768)
  [url_launcher_web] Launch mailto urls in same window in Safari (flutter#2740)
  update README with enableJavaScript info (flutter#2766)
  Run publish ci check on master (flutter#2764)
  [image_picker] Add documentation for Android external storage permissions (flutter#2765)
  [package_info] add support for macos to package_info plugin (flutter#2618)
  fixed detach from engine logic (flutter#2759)
  [url_launcher] Initialize previousAutomaticSystemUiAdjustment in launch (flutter#2757)
  [google_maps_flutter] add todo on skipped test. (flutter#2752)
  [google_maps_flutter] use `WaitUntilTouchesEndedPolicy` to fix the cameraIdle not called issue on iOS (flutter#2746)
  Use Xvfb for Linux desktop tests (flutter#2750)
  update lower dart bound to 2.1.0 (flutter#2751)
  [camera] Update lower bound of dart dependency to 2.1.0. (flutter#2749)
  [battery] update dart deps lower bound to 2.1.0 (flutter#2748)
  [android_alarm_manager] update dart deps lower bound to 2.1.0 (flutter#2747)
  [url_launcher] Add web to example app. (flutter#2736)
  [in_app_purchase] update docs to warn about `completePurchase` (flutter#2739)
  [video_player] upgraded video_player to use pigeon (flutter#2544)
  [video_player]: fixed platform_interface unit tests (flutter#2745)
  [video_player]: added test class to fix video_player unit tests (flutter#2744)
  ...

# Conflicts:
#	packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
* Bump version and some metadata. Ignore generated_plugin_registrant.dart globally.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
* Bump version and some metadata. Ignore generated_plugin_registrant.dart globally.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
* Bump version and some metadata. Ignore generated_plugin_registrant.dart globally.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants