Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] updated VALID_ARCHS to support iPhone simulator #2761

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

jlalvarez18
Copy link
Contributor

@jlalvarez18 jlalvarez18 commented May 14, 2020

Description

Currently the Image Picker plugin no longer works on Xcode 11.4.1 in the iPhone simulator. I updated the podspec to set the VALID_ARCHS to match other plugins in this project.

Related Issues

Fixes flutter/flutter#51395

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jlalvarez18
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jlalvarez18 jlalvarez18 force-pushed the image_picker_ios_fix branch from 29512f3 to fe03ef5 Compare May 14, 2020 15:29
jlalvarez18 pushed a commit to jlalvarez18/plugins that referenced this pull request May 14, 2020
Contains code from the following PRs:

flutter#2761
flutter#2755
@jlalvarez18 jlalvarez18 force-pushed the image_picker_ios_fix branch 2 times, most recently from 6f47483 to 5c5b30f Compare May 16, 2020 17:24
@jlalvarez18
Copy link
Contributor Author

I will wait until reviewed to update the CHANGEDLOG and Pubspec version until approved to avoid all the merge conflicts :)

@jlubeck
Copy link

jlubeck commented Jun 10, 2020

Any thoughts on well this will be merged?

@Nash0x7E2
Copy link

cc: @cyanglaz

@TahaTesser TahaTesser requested a review from jmagman June 30, 2020 11:37
@jmagman
Copy link
Member

jmagman commented Jun 30, 2020

This looks good, thank you for making this change!
The pubspec and CHANGELOG need to be updated, then we'll merge and publish. I can also do this and push to your fork, if you prefer (I know you worked on this more than a month ago).
\cc @cyanglaz

@jmagman jmagman force-pushed the image_picker_ios_fix branch from 5c5b30f to f640127 Compare July 6, 2020 18:35
@jmagman
Copy link
Member

jmagman commented Jul 6, 2020

Took the liberty of pushing the CHANGELOG, pubspec version bump, and AUTHORS to add @jlalvarez18.

@jmagman jmagman requested a review from cyanglaz July 6, 2020 18:36
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a line between the version number and the message in CHANGELOG.md

@jmagman jmagman merged commit a5db6e0 into flutter:master Jul 6, 2020
agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[image_picker] Mapping architecture arm warnings
6 participants