-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[image_picker] updated VALID_ARCHS to support iPhone simulator #2761
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
29512f3
to
fe03ef5
Compare
Contains code from the following PRs: flutter#2761 flutter#2755
6f47483
to
5c5b30f
Compare
I will wait until reviewed to update the CHANGEDLOG and Pubspec version until approved to avoid all the merge conflicts :) |
Any thoughts on well this will be merged? |
cc: @cyanglaz |
This looks good, thank you for making this change! |
5c5b30f
to
f640127
Compare
Took the liberty of pushing the CHANGELOG, pubspec version bump, and AUTHORS to add @jlalvarez18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Added a line between the version number and the message in CHANGELOG.md
Description
Currently the Image Picker plugin no longer works on Xcode 11.4.1 in the iPhone simulator. I updated the podspec to set the VALID_ARCHS to match other plugins in this project.
Related Issues
Fixes flutter/flutter#51395
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?