Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix bug in example #2801

Merged
merged 1 commit into from
Jun 6, 2020
Merged

[camera] Fix bug in example #2801

merged 1 commit into from
Jun 6, 2020

Conversation

panmari
Copy link
Contributor

@panmari panmari commented May 28, 2020

Description

Make the example actually runable by ensuring that flutter widget bindings are initialized. The current version fails on startup.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ened
Copy link
Contributor

ened commented May 29, 2020

@panmari - hi! Could you please bump version & add changelog entry?

By ensuring that flutter widget bindings are initialized. The current version fails on startup.
@panmari
Copy link
Contributor Author

panmari commented May 29, 2020

I was not aware that this is also applicable for documentation-only changes. Done.

@panmari
Copy link
Contributor Author

panmari commented Jun 5, 2020

Bump, is this now good for merging?

Copy link
Contributor

@ened ened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim could you have a quick look as well?

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix.

@mklim mklim merged commit 2fb8bf0 into flutter:master Jun 6, 2020
@panmari panmari deleted the patch-1 branch June 7, 2020 15:58
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
By ensuring that flutter widget bindings are initialized. The current version fails on startup.
agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
By ensuring that flutter widget bindings are initialized. The current version fails on startup.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
By ensuring that flutter widget bindings are initialized. The current version fails on startup.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
By ensuring that flutter widget bindings are initialized. The current version fails on startup.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants