Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update Linux desktop Dockerfile for GTK switch #2826

Merged
merged 3 commits into from
Jun 13, 2020

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jun 11, 2020

Description

Once the switch to GTK lands, libgtk-3-dev will be needed for building.

Related Issues

Part of flutter/flutter#54860

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Once the switch to GTK lands, libgtk-3-dev will be needed for building.

Also updates all the 'apt-get' commands to the more modern 'apt'
@robert-ancell
Copy link
Contributor

I just read the apt man page and noticed it says:

All features of apt(8) are available in dedicated APT tools like apt-get(8) and apt-cache(8) as well. apt(8) just changes the default value of some options (see apt.conf(5) and specifically the Binary scope). So you should prefer using these commands (potentially with some additional options enabled) in your scripts as they keep backward compatibility as much as possible.

So I was wrong when I said you should switch to apt, it turns out apt-get is the correct command to use.

Other than that LGTM.

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 90462df into flutter:master Jun 13, 2020
@stuartmorgan-g stuartmorgan-g deleted the linux-gtk-switch-prep branch June 13, 2020 03:51
agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
Once the switch to GTK lands, libgtk-3-dev will be needed for building.
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Once the switch to GTK lands, libgtk-3-dev will be needed for building.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Once the switch to GTK lands, libgtk-3-dev will be needed for building.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants