This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[e2e] Use SettableFutures instead of CompletableFuture #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works better for internal use cases.
jiahaog
force-pushed
the
dont-use-completable-future
branch
from
5d17791 to
39fbe2c
Compare
dnfield
reviewed
Jun 30, 2020
| public static CompletableFuture<Map<String, String>> testResults = new CompletableFuture<>(); | ||
| private static final SettableFuture<Map<String, String>> testResultsSettable = | ||
| SettableFuture.create(); | ||
| public static final ListenableFuture<Map<String, String>> testResults = testResultsSettable; |
There was a problem hiding this comment.
Can we just make this be a Future instead of needing to publicly export its type?
I'm a little concerned that at some point we'll have a reason to avoid using Guava for this, and we'll have to break people again. I'm also not clear on what benefits consumers get from having this be a ListenableFuture rather than just a Future.
|
Thanks! |
|
Sorry, I've never done this before, should I follow https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md#the-release-process to release it onto pub? |
|
Yes. If you need permissions @kf6gpe can help |
agent3bood
pushed a commit
to agent3bood/flutter-plugins
that referenced
this pull request
Jul 10, 2020
Expose a `Future` for `testResults` instead. This works better for internal use cases.
agent3bood
pushed a commit
to agent3bood/flutter-plugins
that referenced
this pull request
Jul 10, 2020
Missed this earlier in flutter#2854
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
Expose a `Future` for `testResults` instead. This works better for internal use cases.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
Missed this earlier in flutter#2854
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Expose a `Future` for `testResults` instead. This works better for internal use cases.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Missed this earlier in flutter#2854
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This unblocks the import of the plugin internally.
Related Issues
b/160208320
Breaking Change
Breaking change if users depend on
E2EPlugin.testResultsas an instance ofCompletableFuture.