-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[url_launcher_linux] Add Linux url_launcher plugin #2857
[url_launcher_linux] Add Linux url_launcher plugin #2857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have an example and test, as with all the other plugins in flutter/plugins. And we can actually check in the full example app now for Linux, since it's stabilized!
packages/url_launcher/url_launcher_linux/linux/include/url_launcher/url_launcher_plugin.h
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_linux/linux/include/url_launcher/url_launcher_plugin.h
Outdated
Show resolved
Hide resolved
cough url_launcher_macos cough 👀 |
Note that https://cirrus-ci.com/task/6609503187632128 isn't showing any test having run for this package, which is the problem. There should be an example, which the existing test script can run with |
Added tests that should be driven by CI. That found:
|
Still one test failure, which CI isn't picking up (filed flutter/flutter#60943). I suspect the failure means there's no browser installed on the image, so trying a run with Chromium added to the Dockerfile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is now passing after setting up the Docker image correctly. Added the iOS stub, which I just noticed was missing. Assuming everything is green I'll land this tomorrow.
Published; PR to endorse it will follow. |
Adds url_launcher_linux, the federated implementation of url_launcher. Not yet endorsed by url_launcher Part of flutter/flutter#41721
Adds url_launcher_linux, the federated implementation of url_launcher. Not yet endorsed by url_launcher Part of flutter/flutter#41721
Adds url_launcher_linux, the federated implementation of url_launcher. Not yet endorsed by url_launcher Part of flutter/flutter#41721
Description
Add Linux url_launcher plugin.
Related Issues
flutter/flutter#41721
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?