Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher_linux] Add Linux url_launcher plugin #2857

Merged
merged 14 commits into from
Jul 7, 2020

Conversation

robert-ancell
Copy link
Contributor

Description

Add Linux url_launcher plugin.

Related Issues

flutter/flutter#41721

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have an example and test, as with all the other plugins in flutter/plugins. And we can actually check in the full example app now for Linux, since it's stabilized!

@robert-ancell
Copy link
Contributor Author

This should have an example and test, as with all the other plugins in flutter/plugins.

cough url_launcher_macos cough 👀

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jul 4, 2020

This should have an example and test, as with all the other plugins in flutter/plugins.

cough url_launcher_macos cough 👀

https://github.com/flutter/plugins/blob/master/packages/url_launcher/url_launcher_macos/example/test_driver/

Note that https://cirrus-ci.com/task/6609503187632128 isn't showing any test having run for this package, which is the problem. There should be an example, which the existing test script can run with flutter driver. url_launcher_macos has that.

@stuartmorgan-g
Copy link
Contributor

Added tests that should be driven by CI. That found:

  • The example didn't compile, because the CMake project name didn't match the plugin name (url_launcher vs url_launcher_linux)
  • The return value for canLaunch for a bogus URL didn't match the existing mobile test expectations (an error rather than false), so I changed that for consistent behavior with existing code.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jul 7, 2020

Still one test failure, which CI isn't picking up (filed flutter/flutter#60943).

I suspect the failure means there's no browser installed on the image, so trying a run with Chromium added to the Dockerfile.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is now passing after setting up the Docker image correctly. Added the iOS stub, which I just noticed was missing. Assuming everything is green I'll land this tomorrow.

@stuartmorgan-g stuartmorgan-g merged commit 65e7bdb into flutter:master Jul 7, 2020
@stuartmorgan-g
Copy link
Contributor

Published; PR to endorse it will follow.

@robert-ancell robert-ancell deleted the linux-url-launcher branch July 9, 2020 02:36
agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants