Make package:e2e a relative reference #2889
Conversation
dnfield
requested review from
amirh,
LHLL,
matthew-carroll and
mklim
as code owners
|
I'm not sure if this works when those packages (not those files in |
|
Yes, this would mean you cannot run tests in your pub cache, but you shouldn't do that anyway |
dnfield
force-pushed
the
e2e_relative
branch
5 times, most recently
from
eaa4fef to
5db2455
Compare
|
|
|
what about if someone tries to run the example app without downloading the repo though? |
|
@blasten - how would they do that (short of trying to run it from their local .pub-cache, which I don't think we should worry about supporting)? There's no straightforward way of getting just the example app for these projects. And anyone who is willing to do that should be able to just comment out the relative reference to e2e. The bigger value here is that we'll actually know if a change to e2e is breaking (and/or if it's working as expected). We'll also have a clearer path to keeping the plugins up to date with the latest e2e stuff rather than reading several migration guides/changelogs to figure out what actually happened. |
Wouldn't that be the case for 3P plugins? e.g. how would the firebase plugins handle this? |
|
Third party plugins cannot do this - if they want to test against master, they'd have to use a git reference. That's probably not desireable. |
|
To be clear - this is not because we want to recommend this method for other repositories, but because we want to catch regressions in e2e in this repository, and make sure that plugins in this repo are on the latest version of e2e. |
|
It sounds like the issue is test coverage of the e2e plugin itself. Is that correct? :) |
|
It's both getting more coverage of e2e, as well as making sure that the plugin makes repository are using the latest version. |
|
Have to figure out why linux is timing out. |
|
@dnfield maybe related to the latest push to the repo? I've pinged in the merged PR. |
* Make package:e2e a relative reference
* Make package:e2e a relative reference
* Make package:e2e a relative reference
Make sure that we pick up the package as it exists in this repo, rather than whatever happens to be published on pub.
This also meant updating some outdated/deprecated references (FlutterRunner -> FlutterTestRunner) in older usages.
/cc @CareF @digiter