Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Clarify e2e readme for running on firebase test lab #2898

Merged
merged 3 commits into from
Jul 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,12 @@ documentation](https://firebase.google.com/docs/test-lab/?gclid=EAIaIQobChMIs5qV
to set up a project.

To run an e2e test on Android devices using Firebase Test Lab, use gradle commands to build an
instrumentation test for Android.
instrumentation test for Android, after creating `androidTest` as suggested in the last section.

```
```bash
pushd android
# flutter build generates files in android/ for building the app
flutter build apk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is to set the desired runtime mode?

If so we should explain that. If not we should explain why we're doing this

Copy link
Contributor Author

@CareF CareF Jul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this set the runtime mode. This routine still uploads debug app (which I still need to figure out how to get a release/profile testing app), but flutter build generates some files and directories, e.g. ./gradlew. I'm not sure if there's anything else.

./gradlew app:assembleAndroidTest
./gradlew app:assembleDebug -Ptarget=<path_to_test>.dart
popd
Expand All @@ -142,7 +144,7 @@ popd
Upload the build apks Firebase Test Lab, making sure to replace <PATH_TO_KEY_FILE>,
<PROJECT_NAME>, <RESULTS_BUCKET>, and <RESULTS_DIRECTORY> with your values.

```
```bash
gcloud auth activate-service-account --key-file=<PATH_TO_KEY_FILE>
gcloud --quiet config set project <PROJECT_NAME>
gcloud firebase test android run --type instrumentation \
Expand Down