Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity] Making the link a secure link in Readme.md #2901

Closed
wants to merge 4 commits into from

Conversation

agniswarm
Copy link

@agniswarm agniswarm commented Jul 28, 2020

Description

This increases the score for the package on pub.dev

Related Issues

The package score on pub.dev is down by 5 points because of this small issue. This fixes the problem of that 5 points.

image

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This increases the score for the package on pub.dev
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agniswarm agniswarm changed the title connectivity: Making the link a secure link in Readme.md [connectivity] Making the link a secure link in Readme.md Jul 28, 2020
@Zazo032
Copy link
Contributor

Zazo032 commented Jul 28, 2020

Also, this should be flutter.dev instead of flutter.io

@agniswarm
Copy link
Author

@Zazo032 made the necessary changes

@ditman
Copy link
Member

ditman commented Jan 11, 2021

Thanks for the contribution! This issue, alongisde many similar examples in other packages, has been addressed by this big PR: #3276. Some of the plugins haven't been published yet, but pub.dev should reflect the updated scores once they do. Thanks!

@ditman ditman closed this Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants