Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[device_info] Changed directory of device_info #2923

Merged
merged 7 commits into from
Aug 12, 2020
Merged

[device_info] Changed directory of device_info #2923

merged 7 commits into from
Aug 12, 2020

Conversation

yash1200
Copy link
Contributor

Description

In this pr, I have moved everything from device_info to device_info/device_info.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

ditman
ditman suggested changes Aug 12, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the e2e dependency move in the example file!

@ditman
Copy link
Member

ditman commented Aug 12, 2020

(The build_all_plugins_ipa was fixed last night. Please rebase your branch with the latest master to get that test to pass!)

@yash1200
Copy link
Contributor Author

(The build_all_plugins_ipa was fixed last night. Please rebase your branch with the latest master to get that test to pass!)

Sure sir!. I'm on it.

@ditman
Copy link
Member

ditman commented Aug 12, 2020 •
edited
Loading

I'll merge this once the tests in master finish. Thank you very much for your contribution, @yash1200! (And your patience :P)

@yash1200
Copy link
Contributor Author

@ditman Thank you sir. Really means a lot.

@ditman ditman self-requested a review August 12, 2020 22:30
@ditman ditman merged commit 42b33ec into flutter:master Aug 12, 2020
@yash1200 yash1200 deleted the yash_device_info branch August 13, 2020 04:44
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
@yash1200 @jarrodcolburn
[device_info] Moved device_info to a subdir (flutter#2923)
503b567 
(This is preparation for the federation of the plugin)
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@yash1200 @jorgefspereira
[device_info] Moved device_info to a subdir (flutter#2923)
5588bd2 
(This is preparation for the federation of the plugin)
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@yash1200
[device_info] Moved device_info to a subdir (flutter#2923)
993e055 
(This is preparation for the federation of the plugin)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

@matthew-carroll matthew-carroll Awaiting requested review from matthew-carroll

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash1200 @ditman @googlebot