Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Reland "[video_player] Set audio mix options (#2922)" #2939

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

cyanglaz
Copy link
Contributor

Reverts #2938

@dnfield
Copy link
Contributor

dnfield commented Aug 18, 2020

LGTM

@cyanglaz cyanglaz merged commit db329d7 into master Aug 18, 2020
@cyanglaz cyanglaz deleted the revert-2938-revert branch August 18, 2020 03:20
jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
@steve-rait
Copy link

steve-rait commented Aug 27, 2020

Hi, this new feature has a side effect :
In my app, when I upgrade plugin, It can't play multiple videos in the same screen by default anymore (I have a list with many items, one video player by item) (only on Android)
Indeed, this affects multiple players in the app itself (and not only sound).
I had to force VideoPlayerOptions mixWithOthers to true to let them play together again.

So it's a breaking change which need to be detailed somewhere in the doc, don't you think ?

@cyanglaz
Copy link
Contributor Author

@steve-rait This breakage is not intended. Do you mind create a github issue (https://github.com/flutter/flutter/issues/new/choose) describe the failure scenario in details? And preferably, if you could provide a sample code to reproduce the issue, that'd help us to accelerate the debugging process. :)
Feel free to tag me if you create the github issue.

Let me know if you want me to create the issue, but I'd probably need your help to describe it in more details.

@steve-rait
Copy link

Hi
Thanks for the info, let me create it, I'll do that this weekend or next week with a complete sample code to show precisely the problem.

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
FlutterSu pushed a commit to tvip/flutter-plugins that referenced this pull request Mar 26, 2021
FlutterSu pushed a commit to tvip/flutter-plugins that referenced this pull request May 27, 2021
FlutterSu pushed a commit to tvip/flutter-plugins that referenced this pull request Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants