This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add deprecation suppression for plugins marked with -Werror #3072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm marking the v1 embeddings deprecated flutter/engine#20868
Since there are 3 versions involved, the app, the engine and the plugin, we intentionally want to deprecate the plugins and the engine last to not break the app users. However, the engine is connected to both the app and the plugin. Adding deprecation ignores in the plugin lets us deprecate APIs on the engine, showing warnings to the app users while still letting plugins with V1 handling build.
Related Issues
flutter/flutter#43298
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?