Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[share] Fix iPad issue where origin is null #3128

Closed
wants to merge 32 commits into from

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Oct 8, 2020

Description

Workaround a bug where we have to explicitly set the sourceRect to make the share work on iPad

Related Issues

Fixes flutter/flutter#66485

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 8, 2020
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Nov 5, 2020

Fixed in #3210 closing.

@cyanglaz cyanglaz closed this Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Share plugin does not work on iPad iOS 13.3 and above
1 participant