[image_picker] add forceFullMetadata for iOS

[cpboyd]

Description

Originally #3090

Make iOS 11+ permissions requests optional per https://developer.apple.com/forums/thread/653414.
PHAssets aren't actually required and there was already some fallback code in place.

To keep this as a non-breaking change, I added an optional parameter of forceFullMetaData with a default of true.
Setting this to false will disable any permissions checking on iOS and simply display the image picker.

I still need to update the tests.

Related Issues

Fixes flutter/flutter#65995

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[cpboyd]

@cyanglaz I was unable to make any changes to the old PR.
I've made the requested changes and tried to simplify/reduce the description for conciseness.

Please let me know if you'd like me to make any additional changes.

[cyanglaz]

Thanks for the PR, can we add an XCUITest to make sure the permission popup didn't show if forceFullMetaData is false

[cpboyd]

@cyanglaz Should I add a new FAB to the example with {forceFullMetaData: false}?

Also, I suppose I need to create a separate XCTestCase since the current has the UIInterruptionMonitor to automatically accept the permissions, correct? I'm new to XCUITests.

[cyanglaz]

@cpboyd
This is what I have in mind.

1. Create a new fab to the example with {forceFullMetaData: false}.
2. Update the existing test to use the new fab instead.
3. In the existing test, add an assertion that the UIInterruptionMonitor is never trigger.

[cyanglaz]

@cpboyd It's been a while since I last commented, were you able to keep working on this? :)

[cpboyd]

@cyanglaz I hadn't had time for this over the holidays. I'll try to make sure it's up-to-date with master and proceed

[cyanglaz]

@cpboyd Thank you so much! just FYI that we are going to migrate image picker to nnbd soon.

[cpboyd]

@cyanglaz Great! I've been attempting to do the same with my projects

[cyanglaz]

@cpboyd the NNBD migration is done, you can safely rebase your PR. Then I'll review this and let's get this landed :)

[cyanglaz]

@cpboyd Looks like you need another rebase master to fix CI. Please ping me when it's done and I'll do another review. Let's try to land it soon :)

[cpboyd]

@cyanglaz I've rebased, fixed failing tests, and added a checkbox to the example for toggling the forceFullMetadata value.

Please advise next steps.

[cpboyd]

I had corrected the casing to forceFullMetadata, should I revert to forceFullMetaData for consistency per @stuartmorgan's comment on PR #4215 (comment) ?

[stuartmorgan-g]

I had corrected the casing to forceFullMetadata, should I revert to forceFullMetaData for consistency per @stuartmorgan's comment on PR #4215 (comment) ?

Are there other cases where it's wrong in the public API? I was looking at the ObjC code when I made that comment; I don't remember if it extended beyond there.

[cpboyd]

Are there other cases where it's wrong in the public API? I was looking at the ObjC code when I made that comment; I don't remember if it extended beyond there.

From searching etaData, it appears to be limited to the image_picker ObjC code.

[stuartmorgan-g]

Then a new public API should definitely use the correct capitalization.

[cyanglaz]

@cpboyd Thank you very much for this. I apologize for the delay. I just came back from a long time-off.
I think this PR is good to go. There are just a few things left to do:

1. Extract the code in image_picker_platform_interface into a new PR. Then we can land the platform_Interface, publish it.
2. Remove the platform_interface code in this PR.

Once that's done, I can help landing this.

[cyanglaz]

Now that the platform_interface is updated, I think we need to update the version dependency in pubspec.yaml?

[stuartmorgan-g]

This cannot land without first fixing the interface change, which needs to be reverted.

[stuartmorgan-g]

@cpboyd Are you planning on re-implementing the interface change as described here to move this forward?

[cpboyd]

@stuartmorgan I'm sorry, I just don't have the time to dedicate to this PR.

In all honesty, I'm not fully certain about the rebases that I did previously. I stopped using this optional approach in my own app months ago in favor of simply stripping out the permissions elevation code: https://github.com/cpboyd/plugins/tree/ios-no-permissions