Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Revert "[path_provider_windows] Resolve FFI stabilization changes" #3488

Closed
wants to merge 1 commit into from

Conversation

xu-baolin
Copy link
Member

Reverts #3485 to fix the tree.

Running command: "pub global run tuneup check" in /b/s/w/ir/tmp/t/pluginsFHFRRF/packages/path_provider/path_provider_windows
Checking project path_provider_windows...

  error - The method 'setGUID' isn't defined for the type 'Pointer' at lib/src/path_provider_windows_real.dart:119:57 - (undefined_method)

1 issue found; analyzed 11 source files in 4.0s.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8856572090238051232/+/steps/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/0/stdout

CC @timsneath @stuartmorgan

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Feb 1, 2021

I'm confused; the revert introduces the error you say you are fixing.

And from your build log:

! path_provider_windows 0.1.0-nullsafety from path ..

That's the version from before the patch you are trying to revert.

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Feb 1, 2021

If you are seeing this error in current builds, the most likely explanation is a pub cache on the machine in question that has the older version, in which case the fix is to update the minimum path_provider_windows constraint on path_provider, and then update the minimum version of path_provider in the Flutter tree.

@xu-baolin xu-baolin closed this Feb 1, 2021
@timsneath timsneath deleted the revert-3485-timsneath-patch-1 branch February 4, 2021 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants