Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[share] Migrate unit tests to null-safety. #3660

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[share] Migrate unit tests to null-safety. #3660

merged 1 commit into from
Mar 2, 2021

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 2, 2021

This PR migrates package:share unit tests to null-safety.

This removes mockito for a simpler Fake that just logs calls to the method channel.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 2, 2021
cyanglaz
cyanglaz approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (we might not need to update the version since it is only test code and it will get picked up with next release)

@ditman
Copy link
Member Author

ditman commented Mar 2, 2021

LGTM (we might not need to update the version since it is only test code and it will get picked up with next release)

@cyanglaz Hahah I do these in auto-pilot and always upgrade the version and changelog :P

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 2, 2021
@fluttergithubbot fluttergithubbot merged commit 8464890 into flutter:master Mar 2, 2021
@ditman ditman deleted the nnbd-share-tests branch March 2, 2021 21:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2021
@engine-flutter-autoroll
8464890 [share] Migrate unit tests to null-safety. (flutter/plugins#3660
b0827fa 
)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 3, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
a0e64b5 
* master:
  Adopt Xcode 12 for podspec lints (flutter#3653)
  Run static analyzer during xctest (flutter#3667)
  [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662)
  [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663)
  [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664)
  [device_info] Enable NNBD for unit test (flutter#3658)
  remove unused plugin (flutter#3661)
  [android_intent] move unit test to nullsafety (flutter#3659)
  [url_launcher] Migrate unit tests to NNBD (flutter#3657)
  [share] Migrate unit tests to null-safety. (flutter#3660)
  [connectivity_for_web] Migration to null-safety. (flutter#3652)
  [camera] Stable release for null safety. (flutter#3641)
  [in_app_purchase] fix plugin version (flutter#3654)
  Move plugin tool tests over (flutter#3606)
  [in_app_purchase] migrate playing billing library to v3 (flutter#3636)
  Update plugin_platform_interface min version (flutter#3650)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees
No one assigned
Labels
cla: yes p: share waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ditman @cyanglaz @stuartmorgan-g @fluttergithubbot