Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Skip flutter upgrade for pod linting Cirrus task #3700

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Skip flutter upgrade for pod linting Cirrus task #3700

merged 3 commits into from
Mar 11, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 10, 2021 •
edited
Loading

  • Hoist common properties like only_if, use_compute_credits, and env to top of tasks, out of root template.
  • Rename ROOT_TASK_TEMPLATE to FLUTTER_UPGRADE_TEMPLATE.
  • Pull lint_darwin_plugins out from the other macOS tasks and don't apply FLUTTER_UPGRADE_TEMPLATE since it doesn't use flutter tooling, so shouldn't waste the 40 seconds and I/O upgrading.
  • Remove lint_darwin_plugins subsharding. Each subshard takes about 4 minutes, so combining them together the 8 minutes is well within the time length of other tests (especially now that they won't upgrade flutter), and avoid scheduling a second Mac machine. https://cirrus-ci.com/task/6550328981061632
  • Pull tool_setup_script out of flutter_upgrade_template so it can be used directly by the lint_darwin_plugins task.
  • Create MACOS_TEMPLATE and use for both macOS image tasks.

Related to #3697

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Mar 10, 2021
@google-cla google-cla bot added the cla: yes label Mar 10, 2021
jmagman
jmagman commented Mar 10, 2021
View reviewed changes
cyanglaz
cyanglaz approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan-g
stuartmorgan-g approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, but definitely LGTM. Thanks for all the plugin CI TLC :)

@jmagman jmagman merged commit fd52de8 into flutter:master Mar 11, 2021
@jmagman jmagman deleted the macos-tasks branch March 11, 2021 01:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2021
@engine-flutter-autoroll
fd52de8 Skip flutter upgrade for pod linting Cirrus task (flutter/plu…
05dda55 
…gins#3700)
yasargil added a commit to yasargil/plugins that referenced this pull request Mar 18, 2021
@yasargil
Merge branch 'master' into gmain
f6f7fdd 
* master: (49 commits)
  Prep for alignment with Flutter analysis options (flutter#3703)
  [google_maps_flutter_platform_interface] Mark constructors as const for ids (flutter#3718)
  [image_picker] Endorse image_picker_for_web (flutter#3717)
  Add missing licenses, and add a check (flutter#3720)
  [ci] Add libgcrypt to Docker image. (flutter#3711)
  Reorder the checkboxes in the PR template (flutter#3666)
  Re-endorse connectivity_for_web (flutter#3708)
  Fix missing declaration of windows' default_package (flutter#3705)
  Typos in comments (flutter#2846)
  Skip flutter upgrade for pod linting Cirrus task (flutter#3700)
  [cross_file] Delete. (flutter#3698)
  [tool] Improve check version ci so that it enforces the version in CHANGELOG and pubspec matches. (flutter#3678)
  Streamline CI setup, and reenable macOS credits (flutter#3697)
  [video_player] fixed misleading size and aspect ratio documentation (flutter#3668)
  [image_picker] Implemented 2860 and added Unit Test to test functionality (flutter#3685)
  [shared_preferences] Fix concurrent modification of the shared preferences on Android (flutter#3684)
  [extension_google_sign_in_as_googleapis_auth] Deleted. (flutter#3694)
  Skip pod lint tests (flutter#3692)
  [Video_Player] Remove the deprecated API reference. (flutter#3669)
  [google_sign_in] fix test(flutter#3690)
  ...
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 14, 2021
Merged
11 tasks
stuartmorgan-g added a commit that referenced this pull request May 15, 2021
@stuartmorgan-g
Begin migrating tools to NNBD (#3891)
15cedbc 
- Updates dependencies to null-safe versions
- Migrates common.dart (which doesn't depend on anything)
- Migrates common_tests.dart and its one dependency, utils.dart
- Adds build_runner for Mockito mock generation
- Adds a new utility methods for getting arguments that handle both the casting and the removal of nullability to address a common problematic pattern while migrating code.
  - Converts all files, not just the migrated ones, to those new helpers.

Migrating common.dart and utils.dart should unblock a command-by-command migration to null safety.

Reverts the separate of podspect lints into a step that doesn't do a Flutter upgrade
(#3700) because without that step we had a
version of Dart too old to run null-safe tooling.

First step of flutter/flutter#81912
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan-g @fotiDim
Begin migrating tools to NNBD (flutter#3891)
591a694 
- Updates dependencies to null-safe versions
- Migrates common.dart (which doesn't depend on anything)
- Migrates common_tests.dart and its one dependency, utils.dart
- Adds build_runner for Mockito mock generation
- Adds a new utility methods for getting arguments that handle both the casting and the removal of nullability to address a common problematic pattern while migrating code.
  - Converts all files, not just the migrated ones, to those new helpers.

Migrating common.dart and utils.dart should unblock a command-by-command migration to null safety.

Reverts the separate of podspect lints into a step that doesn't do a Flutter upgrade
(flutter#3700) because without that step we had a
version of Dart too old to run null-safe tooling.

First step of flutter/flutter#81912
stuartmorgan-g added a commit to flutter/packages that referenced this pull request Feb 13, 2023
@stuartmorgan-g
Begin migrating tools to NNBD (#3891)
bd00812 
- Updates dependencies to null-safe versions
- Migrates common.dart (which doesn't depend on anything)
- Migrates common_tests.dart and its one dependency, utils.dart
- Adds build_runner for Mockito mock generation
- Adds a new utility methods for getting arguments that handle both the casting and the removal of nullability to address a common problematic pattern while migrating code.
  - Converts all files, not just the migrated ones, to those new helpers.

Migrating common.dart and utils.dart should unblock a command-by-command migration to null safety.

Reverts the separate of podspect lints into a step that doesn't do a Flutter upgrade
(flutter/plugins#3700) because without that step we had a
version of Dart too old to run null-safe tooling.

First step of flutter/flutter#81912
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

Assignees

@jmagman jmagman

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @stuartmorgan-g @cyanglaz