Fix signature errors to account for strong mode errors #380
Conversation
flutter/flutter#14556 (issues encountered when running flutter gallery in strong mode).
|
@a-siva what SDK version ranges does this need to work with? In particular, does it need to work with pre dev.21 releases, or can it use the new core lib methods? |
|
I think @mravn-google would have to answer that question as he owns this package. |
| @@ -173,14 +174,15 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> { | |||
| value = value.copyWith(isPlaying: false); | |||
| timer?.cancel(); | |||
| } else if (map["event"] == "bufferingUpdate") { | |||
| final List<List<int>> bufferedValues = map["values"]; | |||
| final List<dynamic> bufferedValues = map["values"]; | |||
There was a problem hiding this comment.
You could consider using
List<List> bufferedValues = map["values"].cast();
if you wanted to preserve more of the types (and if you are able to use .cast which is available starting in dev.21). This would allow toDurationRange to be typed to take List.
There was a problem hiding this comment.
When I made the change suggested by you
List bufferedValues = map["values"].cast();
I get the following analyzer errors
info - Specify type annotations at lib/video_player.dart:176:20 - (always_specify_types)
info - Specify type annotations at lib/video_player.dart:176:62 - (always_specify_types)
not sure what to make of it.
There was a problem hiding this comment.
I'm not too familiar with always_specify_types, but I'd bet it requires you to write List explicitly instead of just List (and similarly List<List> instead of List).
| @@ -173,14 +173,16 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> { | |||
| value = value.copyWith(isPlaying: false); | |||
| timer?.cancel(); | |||
| } else if (map["event"] == "bufferingUpdate") { | |||
| final List<List<int>> bufferedValues = map["values"]; | |||
| final List<List<dynamic>> bufferedValues = | |||
| map["values"].cast<List<List<dynamic>>>(); | |||
There was a problem hiding this comment.
I think this should be .cast<List>().
|
What can i do about this program being used on me? |
Fix signature errors to account for strong mode errors in
flutter/flutter#14556
(issues encountered when running flutter gallery in strong mode).