[image_picker] Image picker fix metadata #3873

ydag · 2021-05-10T19:15:26Z

This PR fixes a rotation problem where "Select Photos" limited access is chosen but the image that is picked is not included in selected photos and the image is scaled.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cpboyd · 2021-05-11T14:28:21Z

I've noticed that if you try to select this image:

on the iOS simulators without permission, it fails even with these changes. None of the other default images cause the same issue.

Per #3835 (comment), image is nil.

loadObjectOfClass fails with this error:

2021-05-11 10:33:10.432504-0400 Runner[18240:9676219] [claims] Upload preparation for claim 13C254A4-B664-453E-B725-E927126DECE8 completed with error: Error Domain=NSCocoaErrorDomain Code=260 "The file “version=1&uuid=CC95F08C-88C3-4012-9D6D-64A413D254B3&mode=compatible.jpeg” couldn’t be opened because there is no such file." UserInfo={NSURL=file://~/Library/Developer/CoreSimulator/Devices/B68DDD0B-98C1-483B-875C-F025235CC303/data/Containers/Shared/AppGroup/F638EBF0-36D2-4E47-ADC5-9270B11D1CDF/File%20Provider%20Storage/photospicker/version=1&uuid=CC95F08C-88C3-4012-9D6D-64A413D254B3&mode=compatible.jpeg, NSFilePath=~/Library/Developer/CoreSimulator/Devices/B68DDD0B-98C1-483B-875C-F025235CC303/data/Containers/Shared/AppGroup/F638EBF0-36D2-4E47-ADC5-9270B11D1CDF/File Provider Storage/photospicker/version=1&uuid=CC95F08C-88C3-4012-9D6D-64A413D254B3&mode=compatible.jpeg, NSUnderlyingError=0x6000013e3fc0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}

UIImagePicker doesn't exhibit the same issue.

cpboyd · 2021-05-11T14:50:50Z

The specific issue I'm seeing seems related to https://developer.apple.com/forums/thread/654021

At the very bottom of the thread, someone notes:

In the Simulator example images, they are helpful in providing multiple image formats. One includes a ".heic" file, that's not a JPEG. And this is the one that usually borks.

He gave a workaround:

let supportedRepresentations = [UTType.rawImage.identifier,
                                UTType.tiff.identifier,
                                UTType.bmp.identifier,
                                UTType.png.identifier,
                                UTType.heif.identifier,
                                UTType.heic.identifier,
                                UTType.jpeg.identifier,
                                UTType.webP.identifier,
                                UTType.gif.identifier,
]
for representation in supportedRepresentations {
    if result.itemProvider.hasRepresentationConforming(toTypeIdentifier: representation, fileOptions: .init()) {
        result.itemProvider.loadInPlaceFileRepresentation(forTypeIdentifier: representation) { (originalUrl, inPlace, error) in

Have you tested with HEIC and other (non-JPEG) image formats on device?

ydag · 2021-05-11T16:10:09Z

The specific issue I'm seeing seems related to https://developer.apple.com/forums/thread/654021

At the very bottom of the thread, someone notes:

In the Simulator example images, they are helpful in providing multiple image formats. One includes a ".heic" file, that's not a JPEG. And this is the one that usually borks.

He gave a workaround:

let supportedRepresentations = [UTType.rawImage.identifier,
                                UTType.tiff.identifier,
                                UTType.bmp.identifier,
                                UTType.png.identifier,
                                UTType.heif.identifier,
                                UTType.heic.identifier,
                                UTType.jpeg.identifier,
                                UTType.webP.identifier,
                                UTType.gif.identifier,
]
for representation in supportedRepresentations {
    if result.itemProvider.hasRepresentationConforming(toTypeIdentifier: representation, fileOptions: .init()) {
        result.itemProvider.loadInPlaceFileRepresentation(forTypeIdentifier: representation) { (originalUrl, inPlace, error) in

Have you tested with HEIC and other (non-JPEG) image formats on device?

Hi @cpboyd , thanks for the review!

Yes, I have tested with the HEIC format. But as you mentioned above there is a known issue related to PHPicker that I guess we need to wait until it is solved by Apple and I explained here why I changed the UITest as well.

cpboyd · 2021-05-11T16:43:12Z

@ydag Ah, so the JPEG transcoding is simulator only?

Is the transcoding expected from PHPicker or does this only occur when not given full permissions to the image?

ydag · 2021-05-11T18:09:31Z

@cpboyd This is not about the permissions. Even with full permission, it will fail on the simulator.

cyanglaz · 2021-05-11T19:01:32Z

packages/image_picker/image_picker/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.7.6


Since there's no publish API change, it should be 0.7.5+1

cyanglaz · 2021-05-11T19:02:12Z

packages/image_picker/image_picker/ios/Classes/FLTImagePickerImageUtil.h

@@ -20,7 +20,8 @@ NS_ASSUME_NONNULL_BEGIN

 + (UIImage *)scaledImage:(UIImage *)image
                maxWidth:(NSNumber *)maxWidth
-               maxHeight:(NSNumber *)maxHeight;
+               maxHeight:(NSNumber *)maxHeight
+    metadataAvailability:(BOOL)metadataAvailability;


since it's a bool, the name should be more like a bool, maybe isMetadataAvailable

cyanglaz · 2021-05-11T19:04:42Z

packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m

+                      [FLTImagePickerImageUtil scaledImage:localImage
+                                                  maxWidth:maxWidth
+                                                 maxHeight:maxHeight
+                                      metadataAvailability:originalAsset == nil ? NO : YES];


can simply be metadataAvailability:originalAsset != nil];

ditto below

cyanglaz · 2021-05-11T19:05:24Z

packages/image_picker/image_picker/ios/Tests/ImageUtilTests.m

+  UIImage *newImage = [FLTImagePickerImageUtil scaledImage:image
+                                                  maxWidth:@3
+                                                 maxHeight:@2
+                                      metadataAvailability:YES];


can you also test the scenario with no meta data?

cyanglaz

LGTM

fluttergithubbot · 2021-05-13T22:54:04Z

This pull request is not suitable for automatic merging in its current state.

This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

This PR fixes a rotation problem where "Select Photos" limited access is chosen but the image that is picked is not included in selected photos and the image is scaled.

This PR fixes a rotation problem where "Select Photos" limited access is chosen but the image that is picked is not included in selected photos and the image is scaled. # Conflicts: # packages/image_picker/image_picker/pubspec.yaml

ydag added 4 commits May 10, 2021 16:51

Refactor scaleImage method to handle nil metadata

006c665

Refactor the unit test to add extra parameter

936ff6b

Update the version number

d02c78a

Add the description into CHANGELOG file

cbcc751

ydag requested a review from cyanglaz as a code owner May 10, 2021 19:15

google-cla bot added the cla: yes label May 10, 2021

github-actions bot added p: image_picker platform-ios labels May 10, 2021

Merge branch 'master' into image_picker_fix_metadata

10d2920

cyanglaz suggested changes May 11, 2021

View reviewed changes

ydag added 4 commits May 11, 2021 21:18

Fix the version number

74c64ae

Fix name convention

eb07255

Refactor the statement

d28036b

Add unit test for no metadata

570603a

ydag mentioned this pull request May 12, 2021

[image_picker] Image picker fix alert #3881

Merged

11 tasks

cyanglaz approved these changes May 13, 2021

View reviewed changes

cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 13, 2021

fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 13, 2021

cyanglaz merged commit 95a0a5c into flutter:master May 13, 2021

github-actions bot added the needs-publishing label May 13, 2021

ydag mentioned this pull request May 17, 2021

ImagePicker.pickImage max size using long side and short side flutter/flutter#55907

Closed

stuartmorgan-g removed the needs-publishing label May 18, 2021

ydag mentioned this pull request May 19, 2021

[image_picker] Image picker fix camera device #3898

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request May 19, 2021

Roll Plugins from 0c99a3ba749b to cb465b7f5418 (40 revisions) flutter/flutter#82923

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021

95a0a5c [image_picker] Image picker fix metadata (flutter/plugins#3873)

81851f2

engine-flutter-autoroll mentioned this pull request May 19, 2021

Roll Plugins from 0c99a3ba749b to db7e1a545682 (55 revisions) flutter/flutter#82927

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021

95a0a5c [image_picker] Image picker fix metadata (flutter/plugins#3873)

0737712

engine-flutter-autoroll mentioned this pull request May 19, 2021

Roll Plugins from 0c99a3ba749b to 4277ce980af0 (58 revisions) flutter/flutter#82932

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021

95a0a5c [image_picker] Image picker fix metadata (flutter/plugins#3873)

d2fd7a0

ydag mentioned this pull request Jun 7, 2021

[image_picker] Fix rotation when camera is a source #4019

Merged

11 tasks

mvanbeusekom deleted the image_picker_fix_metadata branch September 21, 2021 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker] Image picker fix metadata #3873

[image_picker] Image picker fix metadata #3873

ydag commented May 10, 2021 •

edited

Loading

cpboyd commented May 11, 2021 •

edited

Loading

cpboyd commented May 11, 2021 •

edited

Loading

ydag commented May 11, 2021

cpboyd commented May 11, 2021

ydag commented May 11, 2021

cyanglaz May 11, 2021

ydag May 11, 2021

cyanglaz May 11, 2021

ydag May 11, 2021

cyanglaz May 11, 2021

ydag May 12, 2021

cyanglaz May 11, 2021

ydag May 12, 2021

cyanglaz left a comment

fluttergithubbot commented May 13, 2021

[image_picker] Image picker fix metadata #3873

[image_picker] Image picker fix metadata #3873

Conversation

ydag commented May 10, 2021 • edited Loading

Pre-launch Checklist

cpboyd commented May 11, 2021 • edited Loading

cpboyd commented May 11, 2021 • edited Loading

ydag commented May 11, 2021

cpboyd commented May 11, 2021

ydag commented May 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

fluttergithubbot commented May 13, 2021

ydag commented May 10, 2021 •

edited

Loading

cpboyd commented May 11, 2021 •

edited

Loading

cpboyd commented May 11, 2021 •

edited

Loading