This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Federate mobile implementations #4515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As with my recent similar PRs, there's a sequence of individual commits that are probably easier to review than the PR as a whole. |
stuartmorgan-g
force-pushed
the
url-launcher-full-federation
branch
from
91bdd12 to
81173cb
Compare
stuartmorgan-g
force-pushed
the
url-launcher-full-federation
branch
from
81173cb to
f306e25
Compare
|
Weird, I'll push a merge to kick the tests off again. |
|
@bparrishMines Everything is passing now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks `url_launcher` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure. Temporarily marks `url_launcher` as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form. Part of flutter/flutter#68498
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully federates the plugin by moving the existing mobile implementations to their own packages, per planned repo structure.
Temporarily marks
url_launcheras unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form.Part of flutter/flutter#68498
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).