-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Update all plugins that use verifyToken
to use verify
instead
#4643
Update all plugins that use verifyToken
to use verify
instead
#4643
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
verify
method in plugin_platform_interfaceverify
method in plugin_platform_interface
…latform_plugin_interface 2.1.0.
d42b71b
to
7abd84a
Compare
verify
method in plugin_platform_interfaceverifyToken
to use verify
instead
963aec9
to
7abd84a
Compare
…0 versions, since 2.1.0 is forward-compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG other than version issue
sdk: flutter | ||
meta: ^1.3.0 | ||
plugin_platform_interface: ^2.0.0 | ||
plugin_platform_interface: '>=2.1.0 <4.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the final version of the platform interface chance doesn't require any breaking changes (the deprecation after this all lands is just a minor bump per semver and standard Dart package practice), these should all be ^2.1.0
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what I had in a previous version of this PR, and I've reverted back to it.
…low 3.0.0 versions, since 2.1.0 is forward-compatible." This reverts commit 7938460.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing all this cleanup!
test-exempt: code refactor with no semantic change |
This pull request is not suitable for automatic merging in its current state.
|
Thanks for the cleanup @collinjackson! Long time no see! |
#4640 (reviewed by @stuartmorgan) updated
plugin_plugin_interface
to 2.1.0, soft-deprecatingverifyToken
and introducing its replacement,verify
.Now that 2.1.0 has been published, this PR updates all of the first-party plugins that used
verifyToken
to useverify
and depend on^2.1.0
:It is a follow-on fix for flutter/flutter#96178
Test plan
This PR has no new tests because it's not possible to test; there was no semantic change to the above plugins. They are not using
const Object()
as their token so a test cannot cause the newAssertionError
to be thrown. I believe this means @Hixie has to sign off on it and I've posted in #hackers-ecosystem about that.However, this PR does contain new tests in the sense that there are new tests in #4640 and this is a follow-on PR that could only be landed after that one did because of the
plugin_platform_interface
dependency. In some sense this repo is a giant test case and we're testing #4640 by creating lots of sample apps that depend on it.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style].///
).