This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera]remove CAS operation and use dispatch queue instead #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
force-pushed
the
camera_pixel_buffer
branch
11 times, most recently
from
4bd27c1 to
97cbe87
Compare
hellohuanlin
force-pushed
the
camera_pixel_buffer
branch
from
97cbe87 to
5bb5051
Compare
stuartmorgan-g
suggested changes
Mar 2, 2022
packages/camera/camera/example/ios/RunnerTests/CameraTestUtils.h
Outdated
Show resolved
Hide resolved
packages/camera/camera/example/ios/RunnerTests/FLTCamSampleBufferTests.m
Show resolved
Hide resolved
11 tasks
stuartmorgan-g
suggested changes
Mar 7, 2022
packages/camera/camera/example/ios/RunnerTests/CameraTestUtils.m
Outdated
Show resolved
Hide resolved
packages/camera/camera/example/ios/RunnerTests/CameraTestUtils.h
Outdated
Show resolved
Hide resolved
hellohuanlin
force-pushed
the
camera_pixel_buffer
branch
from
6902ead to
e112831
Compare
hellohuanlin
force-pushed
the
camera_pixel_buffer
branch
from
e112831 to
f0878e9
Compare
hellohuanlin
added
the
waiting for tree to go green
jmagman
approved these changes
Mar 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the CompareAndSwap (CAS) operation and replaces it with a dispatch queue, as discussed in the proposal.
Also removed
volatilekeyword since dispatch queues are already memory barriers.I only added tests related to
latestPixelBufferwhich is the scope of this PR. But in the future we should add more sample buffer tests because it's one of the most complicated piece for this plugin, which it has almost zero coverage.This should be the last required item listed in flutter/flutter#96429.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.