This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Reduce server dependencies in tests #5103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2022
|
Ha! I just needed to do something similar for video_player_web (not merged yet): 94b821a |
ditman
approved these changes
Mar 23, 2022
| @@ -56,7 +59,7 @@ void main() { | |||
| (WidgetTester tester) async { | |||
| final VideoPlayerController networkController = | |||
| VideoPlayerController.network( | |||
| 'https://cph-p2p-msl.akamaized.net/hls/live/2000341/test/master.m3u8', | |||
| 'https://flutter.github.io/assets-for-api-docs/assets/videos/hls/bee.m3u8', | |||
There was a problem hiding this comment.
How do you upload stuff to assets-for-api-docs? Is it the website repo?
There was a problem hiding this comment.
It's a separate repo; this was: flutter/assets-for-api-docs#178
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Reduce test dependencies on servers that the Flutter team doesn't control: - Switches webm URL to the GitHub URL for the example asset, matching the existing mp4 setup - Switches m3u8 URL to the assets-for-api-docs URL that was recently added for a native iOS video_player test Ideally these would use local web severs, but initial attempts to serve binary assets via the local web server didn't work, and I won't have time to investigate further in the short term. This is an incremental improvement, and adds TODOs to fully convert.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce test dependencies on servers that the Flutter team doesn't control:
matching the existing mp4 setup
recently added for a native iOS video_player test
Ideally these would use local web severs, but initial attempts to
serve binary assets via the local web server didn't work, and I won't have
time to investigate further in the short term. This is an incremental
improvement, and adds TODOs to fully convert.
No CHANGELOG change: Only internal test details are changing
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).