This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[image_picker] add requestFullMetadata for iOS (optional permissions) - platform interface changes for multi image picking #5914
[image_picker] add requestFullMetadata for iOS (optional permissions) - platform interface changes for multi image picking #5914
Changes from all commits
a4e4612
b3a68bb
040609f
b4cb48d
f3d851f
527ec7c
6f015f8
d745335
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would share this with
ImagePickerOptions
, and extract a shared class that has the elements that are image-specific (i.e., everything here), and then an outer class with anything else. We don't need to do another change to the singe-image version now, but we should prep for it by structuring this that way: all of the fields here should move to a newImageOptions
, and thenMultiImagePickerOptions
should have oneImageOptions
field. Eventually we can switch the single-image version to useImageOptions
instead of these four fields too.