This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[image_picker] add requestFullMetadata for iOS (optional permissions) - platform interface changes for multi image picking #5914
Merged
stuartmorgan-g
merged 8 commits into
flutter:main
from
PiotrMitkowski:ios-optional-permissions-interface
Jul 26, 2022
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a4e4612
Added fullMetadata argument to multi image picking method
PiotrMitkowski b3a68bb
Added tests covering the new argument
PiotrMitkowski 040609f
Updated changelog
PiotrMitkowski b4cb48d
PR remarks
PiotrMitkowski f3d851f
Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…
PiotrMitkowski 527ec7c
Fixed failing tests
PiotrMitkowski 6f015f8
PR remarks
PiotrMitkowski d745335
PR remarks - restored nullability on imageQuality
PiotrMitkowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
packages/image_picker/image_picker_platform_interface/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
packages/image_picker/image_picker_platform_interface/lib/src/types/image_options.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
/// Specifies image-specific options for picking. | ||
class ImageOptions { | ||
/// Creates an instance with the given [maxHeight], [maxWidth], [imageQuality] | ||
/// and [requestFullMetadata]. | ||
const ImageOptions({ | ||
this.maxHeight, | ||
this.maxWidth, | ||
this.imageQuality, | ||
this.requestFullMetadata = true, | ||
}); | ||
|
||
/// The maximum width of the image, in pixels. | ||
/// | ||
/// If null, the image will only be resized if [maxHeight] is specified. | ||
final double? maxWidth; | ||
|
||
/// The maximum height of the image, in pixels. | ||
/// | ||
/// If null, the image will only be resized if [maxWidth] is specified. | ||
final double? maxHeight; | ||
|
||
/// Modifies the quality of the image, ranging from 0-100 where 100 is the | ||
/// original/max quality. | ||
/// | ||
/// Compression is only supported for certain image types such as JPEG. If | ||
/// compression is not supported for the image that is picked, a warning | ||
/// message will be logged. | ||
/// | ||
/// If null, the image will be returned with the original quality. | ||
final int? imageQuality; | ||
|
||
/// If true, requests full image metadata, which may require extra permissions | ||
/// on some platforms, (e.g., NSPhotoLibraryUsageDescription on iOS). | ||
// | ||
// Defaults to true. | ||
final bool requestFullMetadata; | ||
} |
16 changes: 16 additions & 0 deletions
16
...mage_picker/image_picker_platform_interface/lib/src/types/multi_image_picker_options.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
import 'package:image_picker_platform_interface/src/types/image_options.dart'; | ||
|
||
/// Specifies options for picking multiple images from the device's gallery. | ||
class MultiImagePickerOptions { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally we would share this with |
||
/// Creates an instance with the given [imageOptions]. | ||
const MultiImagePickerOptions({ | ||
this.imageOptions = const ImageOptions(), | ||
}); | ||
|
||
/// The image-specific options for picking. | ||
final ImageOptions imageOptions; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.